Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: several parity issues #3540

Merged
merged 4 commits into from
Apr 7, 2021
Merged

port: several parity issues #3540

merged 4 commits into from
Apr 7, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3536
Fixes #3537
Fixes #3538
Fixes #3539

@joshgummersall joshgummersall requested review from chrimc62, tomlm and a team as code owners April 7, 2021 17:00
@joshgummersall joshgummersall changed the title Jpg/port more things port: several parity issues Apr 7, 2021
@coveralls
Copy link

coveralls commented Apr 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 726749985

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.003%) to 84.894%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.92%
libraries/botbuilder-dialogs/src/dialogHelper.ts 2 96.5%
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
Totals Coverage Status
Change from base Build 724796865: -0.003%
Covered Lines: 18963
Relevant Lines: 21277
💛 - Coveralls

johnataylor
johnataylor approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@johnataylor johnataylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but also asked @Stevenic to take a look (I was cherry picking a couple of his PRs along with mine.)

Stevenic
Stevenic approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@joshgummersall joshgummersall merged commit 023e244 into main Apr 7, 2021
@joshgummersall joshgummersall deleted the jpg/port-more-things branch April 7, 2021 18:52
joshgummersall added a commit that referenced this pull request Apr 7, 2021
@joshgummersall
port: several parity issues (#3540)
77992ee 
* port: pass through dialog state manager config

Fixes #3538

* port: turn memory scope exclude from snapshot

Fixes #3539

* port: update default property path for oauth input

Fixes #3536

* port: update http request default result property

Fixes #3537
joshgummersall added a commit that referenced this pull request Apr 7, 2021
@joshgummersall
port: several parity issues (#3540) (#3542)
4dddf77 
* port: pass through dialog state manager config

Fixes #3538

* port: turn memory scope exclude from snapshot

Fixes #3539

* port: update default property path for oauth input

Fixes #3536

* port: update http request default result property

Fixes #3537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Stevenic approved these changes

@johnataylor johnataylor johnataylor approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@joshgummersall @coveralls @Stevenic @johnataylor