Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint rule to reserve backticks for string templating #3685

Closed
stevengum opened this issue May 13, 2021 · 0 comments · Fixed by #3850
Closed

Add eslint rule to reserve backticks for string templating #3685

stevengum opened this issue May 13, 2021 · 0 comments · Fixed by #3850
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc.

Comments

@stevengum
Copy link
Member

We should probably eslint this - IMO backticks should be reserved for templating.

Originally posted by @joshgummersall in #3627 (comment)

If single quotes are used in a string, the wrapping quote should be double quotes.
@stevengum stevengum added the Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. label May 13, 2021
@stevengum stevengum mentioned this issue May 13, 2021
Merged
joshgummersall pushed a commit that referenced this issue Jul 7, 2021
chore: eslint quotes rule
f120999 
Fixes #3685
@joshgummersall joshgummersall mentioned this issue Jul 7, 2021
Merged
stevengum pushed a commit that referenced this issue Jul 7, 2021
chore: estlint quotes rule (#3850)
0fdf7c4 
* chore: eslint quotes rule

Fixes #3685

* fix: lint --fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: estlint quotes rule microsoft/botbuilder-js
1 participant
@stevengum