Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: estlint quotes rule #3850

Merged
merged 2 commits into from
Jul 7, 2021
Merged

chore: estlint quotes rule #3850

merged 2 commits into from
Jul 7, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3685

@joshgummersall joshgummersall requested review from a team as code owners July 7, 2021 17:08
@joshgummersall joshgummersall changed the title Jpg/eslint quotes chore: estlint quotes rule Jul 7, 2021
@coveralls
Copy link

coveralls commented Jul 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1008829565

  • 10 of 16 (62.5%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.341%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai/src/luisAdaptiveRecognizer.ts 0 1 0.0%
libraries/botframework-connector/src/auth/jwtTokenValidation.ts 0 1 0.0%
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts 0 2 0.0%
libraries/botbuilder-azure-queues/src/azureQueueStorage.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 1005627631: 0.0%
Covered Lines: 19671
Relevant Lines: 22128
💛 - Coveralls

stevengum
stevengum approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit:

@stevengum stevengum merged commit 0fdf7c4 into main Jul 7, 2021
@stevengum stevengum deleted the jpg/eslint-quotes branch July 7, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add eslint rule to reserve backticks for string templating
3 participants
@joshgummersall @coveralls @stevengum