Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: addition remark doc comments (#5734) #3809

Closed
github-actions bot opened this issue Jun 24, 2021 · 0 comments · Fixed by #3838
Closed

port: addition remark doc comments (#5734) #3809

github-actions bot opened this issue Jun 24, 2021 · 0 comments · Fixed by #3838
Assignees
@joshgummersall
Labels
Area: Runtime Work related to the core runtime parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

The changes in addition remark doc comments (#5734) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5598

Just a step I'm sure we could do more.

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Jun 24, 2021
@joshgummersall joshgummersall self-assigned this Jun 24, 2021
@joshgummersall joshgummersall added Area: Runtime Work related to the core runtime and removed ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jun 24, 2021
joshgummersall pushed a commit that referenced this issue Jul 1, 2021
port: runtime docs
e7eb47f 
Fixes #3809

Also adds some types to ServiceCollection calls
@joshgummersall joshgummersall mentioned this issue Jul 1, 2021
Merged
joshgummersall pushed a commit that referenced this issue Jul 2, 2021
@mdrichardson
port: runtime docs (#3838)
5a9889c 
* port: runtime docs

Fixes #3809

Also adds some types to ServiceCollection calls

* spellcheck!

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>
joshgummersall pushed a commit that referenced this issue Jul 2, 2021
@mdrichardson
port: runtime docs (#3838)
fda981c 
* port: runtime docs

Fixes #3809

Also adds some types to ServiceCollection calls

* spellcheck!

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>
joshgummersall pushed a commit that referenced this issue Jul 2, 2021
@tsuwandy @mdrichardson
feat: cherrypick orchestrator fix, runtime docs (#3845)
c4d0d5b 
* fix: Bug in orchestratorRecognizer.ts InitializeModel (#3842)

* Update orchestratorRecognizer.ts

fixed bug in initializemodel

* Update orchestratorRecognizer.ts

if load with entity model fail, the no need to fall back to intent only

* port: runtime docs (#3838)

* port: runtime docs

Fixes #3809

Also adds some types to ServiceCollection calls

* spellcheck!

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>

Co-authored-by: Tien Suwandy <tiens@microsoft.com>
Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshgummersall joshgummersall

Labels
Area: Runtime Work related to the core runtime parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: runtime docs microsoft/botbuilder-js
1 participant
@joshgummersall