Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: runtime docs #3838

Merged
merged 3 commits into from
Jul 2, 2021
Merged

port: runtime docs #3838

merged 3 commits into from
Jul 2, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3809

Fixes #3809

Also adds some types to ServiceCollection calls
@joshgummersall joshgummersall requested review from a team as code owners July 1, 2021 19:40
@joshgummersall joshgummersall requested review from tomlm and luhan2017 July 1, 2021 19:40
@coveralls
Copy link

coveralls commented Jul 1, 2021

Pull Request Test Coverage Report for Build 994165812

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.329%

Totals Coverage Status
Change from base Build 992195184: -0.003%
Covered Lines: 19629
Relevant Lines: 22079

💛 - Coveralls

Josh Gummersall and others added 2 commits July 1, 2021 13:21
Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>
@joshgummersall joshgummersall merged commit 5a9889c into main Jul 2, 2021
@joshgummersall joshgummersall deleted the jpg/runtime-remarks-port branch July 2, 2021 16:32
joshgummersall pushed a commit that referenced this pull request Jul 2, 2021
* port: runtime docs

Fixes #3809

Also adds some types to ServiceCollection calls

* spellcheck!

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>
joshgummersall pushed a commit that referenced this pull request Jul 2, 2021
* fix: Bug in orchestratorRecognizer.ts InitializeModel (#3842)

* Update orchestratorRecognizer.ts

fixed bug in initializemodel

* Update orchestratorRecognizer.ts

if load with entity model fail, the no need to fall back to intent only

* port: runtime docs (#3838)

* port: runtime docs

Fixes #3809

Also adds some types to ServiceCollection calls

* spellcheck!

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>

Co-authored-by: Tien Suwandy <tiens@microsoft.com>
Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: addition remark doc comments (#5734)
4 participants