Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Add TelemetryLoggerConstants for adaptive. (#6029) #4006

Closed
github-actions bot opened this issue Dec 8, 2021 · 0 comments · Fixed by #4033
Closed

port: Add TelemetryLoggerConstants for adaptive. (#6029) #4006

github-actions bot opened this issue Dec 8, 2021 · 0 comments · Fixed by #4033
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. P2 Nice to have parity The issue describes a gap in parity between two or more platforms.
Milestone
R16

Comments

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

The changes in Add TelemetryLoggerConstants for adaptive. (#6029) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

also update 'GeneratorResult' events, adding a 'context' property.

Fixes #5020

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Dec 8, 2021
@mrivera-ms mrivera-ms added the P2 Nice to have label Dec 8, 2021
@mrivera-ms mrivera-ms added this to the R16 milestone Dec 8, 2021
@sw-joelmut sw-joelmut mentioned this issue Dec 30, 2021
Merged
@mrivera-ms mrivera-ms removed the needs-triage The issue has just been created and it has not been reviewed by the team. label Mar 3, 2022
EricDahlvang added a commit that referenced this issue Mar 16, 2022
@sw-joelmut @ceciliaavila @EricDahlvang
port: [#4006] Add TelemetryLoggerConstants for adaptive. (#6029) (#4033)
cde0370 
* Port telemetry constants from DotNet

* Add telemetry constants into the unit tests

* Fix typo

Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>

* Update project signature

* Add missing semicolons

Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
Co-authored-by: CeciliaAvila <cecilia.avila@southworks.com>
Co-authored-by: Eric Dahlvang <erdahlva@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. P2 Nice to have parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
R16
Development

Successfully merging a pull request may close this issue.

port: [#4006] Add TelemetryLoggerConstants for adaptive. (#6029) microsoft/botbuilder-js
2 participants
@JuanAr @mrivera-ms