Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4006] Add TelemetryLoggerConstants for adaptive. (#6029) #4033

Merged
merged 8 commits into from
Mar 16, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #4006

Description

This PR adds the TelemetryLoggerConstants class and updates all the hard-coded string references to use the property that corresponds. These changes are ported from DotNet.

Specific Changes

  • Adds the TelemetryLoggerConstants class.
  • Updates all the hard-coded strings to use each specific property declared in the TelemetryLoggerConstants class, including unit tests.
  • Updated the beginSkill to use the constant that corresponds with no addition of a new context property, since this case does not exist in DotNet's port.

Testing

The following images show an overview of the project building correctly to execute the tests successfully.
imagen

@sw-joelmut sw-joelmut requested a review from a team as a code owner December 30, 2021 13:17
@coveralls
Copy link

coveralls commented Dec 30, 2021

Pull Request Test Coverage Report for Build 1995408074

  • 32 of 32 (100.0%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.575%

Totals Coverage Status
Change from base Build 1971383171: 0.01%
Covered Lines: 19702
Relevant Lines: 22068

💛 - Coveralls

@EricDahlvang EricDahlvang merged commit cde0370 into main Mar 16, 2022
@EricDahlvang EricDahlvang deleted the southworks/add/telemetry-constants branch March 16, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Add TelemetryLoggerConstants for adaptive. (#6029)
4 participants