Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6368] SDK uses deprecated Microsoft.Azure.DocumentDB.Core library (#6370) #4272

Closed
github-actions bot opened this issue Jul 5, 2022 · 0 comments · Fixed by #4292
Closed

port: [#6368] SDK uses deprecated Microsoft.Azure.DocumentDB.Core library (#6370) #4272

github-actions bot opened this issue Jul 5, 2022 · 0 comments · Fixed by #4292
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

The changes in [#6368] SDK uses deprecated Microsoft.Azure.DocumentDB.Core library (#6370) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6368

Note: This PR introduces breaking changes by removing deprecated classes in Bot.Builder.Azure (see comment).

The Compat check will fail for this library (You can skip it from the checks by adding the classes' names to the pipeline variable ApiCompatExcludeClasses following this structure: [Package]+[Class] (e.g.: Microsoft.Bot.Builder.Azure.CosmosDbStorage)).

Description

This PR removes the deprecated package Microsoft.Azure.DocumentDB.Core from Microsoft.Bot.Builder.Azure project along with the deprecated CosmosDbStorage classes that used it to avoid security warnings due to the lack of support for this library.

Specific Changes

  • Removed deprecated Microsoft.Azure.DocumentDB.Core from Microsoft.Bot.Builder.Azure project.
  • Removed deprecated classes: CosmosDbStorage, CosmosSbCustomClientOptions, and CosmosDbStorageOptions.
  • Removed test class CosmosDbStorageTests.

Testing

This image shows the unit tests passing after the changes.
image

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Jul 5, 2022
@sw-joelmut sw-joelmut mentioned this issue Jul 22, 2022
Merged
tracyboehrer pushed a commit that referenced this issue Jul 26, 2022
@sw-joelmut
port: [#4272] SDK uses deprecated Microsoft.Azure.DocumentDB.Core lib…
c54b03f 
…rary (#6370) (#4292)

* Remove CosmosDbStorage class and related code

* Update CosmosDbStorage compat and doc

* Remove CosmosDbStorage TestData
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
1 participant
@JuanAr