Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4272] SDK uses deprecated Microsoft.Azure.DocumentDB.Core library (#6370) #4292

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #4272

Note: This PR introduces breaking changes by removing deprecated classes in botbuilder-azure.

Description

This PR removes the deprecated package documentdb from the botbuilder-azure project, along with the deprecated CosmosDbStorage classes that used it to avoid security warnings due to the lack of support for this library.

Specific Changes

  • Removed deprecated documentdb and unused semaphore dependencies from botbuilde-azure library.
  • Removed deprecated classes: CosmosDbStorage and CosmosDbStorageSettings.
  • Removed test file cosmosDbStorage.test.js.
  • Removed unused TestData files that were used in the unit tests.
  • Updated documentation and compatibility.

Testing

This image shows the unit tests passing after the changes.
imagen

@sw-joelmut sw-joelmut requested a review from a team as a code owner July 22, 2022 14:38
@tracyboehrer tracyboehrer merged commit c54b03f into main Jul 26, 2022
@tracyboehrer tracyboehrer deleted the southworks/delete/cosmosdb-storage branch July 26, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: [#6368] SDK uses deprecated Microsoft.Azure.DocumentDB.Core library (#6370)
2 participants