Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade restify to fix error on Node version 18+ #4520

Closed
ceciliaavila opened this issue Aug 17, 2023 · 0 comments · Fixed by #4528
Closed

Upgrade restify to fix error on Node version 18+ #4520

ceciliaavila opened this issue Aug 17, 2023 · 0 comments · Fixed by #4528
Assignees
@ceciliaavila
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@ceciliaavila
Copy link
Collaborator

Versions

4.20.0

Describe the bug

The current version of restify leads to the following error on Node 18+:

➜  my-echo-bot npm start

> my-echo-bot@1.0.0 start
> node ./index.js

/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/request.js:848
    Request.prototype.closed = function closed() {
                             ^

TypeError: Cannot set property closed of #<Readable> which has only a getter
    at patch (/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/request.js:848:30)
    at Object.<anonymous> (/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/server.js:33:1)

Additional context

PR #4515 upgraded restify for JS echo bot template. We need to update the other templates (empty and core) and the TS versions as well.
@ceciliaavila ceciliaavila added the bug Indicates an unexpected problem or an unintended behavior. label Aug 17, 2023
@ceciliaavila ceciliaavila self-assigned this Aug 17, 2023
@ceciliaavila ceciliaavila mentioned this issue Aug 17, 2023
Merged
@ceciliaavila ceciliaavila mentioned this issue Aug 24, 2023
Merged
tracyboehrer pushed a commit that referenced this issue Sep 6, 2023
@ceciliaavila
fix: [#4520] Upgrade restify to fix error on Node version 18+ (#4528)
3685e5e 
* Upgrade restify in JS and TS generators

* Upgrade botbuilder version in generators

* Fix lint issue in core bot TS
@matthieudelaro matthieudelaro mentioned this issue Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [#4520] Upgrade restify to fix error on Node version 18+ microsoft/botbuilder-js
1 participant
@ceciliaavila