Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrading restify to fix error on Node version 18+ #4515

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

GregBorrelly
Copy link
Contributor

@GregBorrelly GregBorrelly commented Aug 6, 2023

#minor

Description

Current version of restify leads to the following error on Node 18+:

➜  my-echo-bot npm start

> my-echo-bot@1.0.0 start
> node ./index.js

/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/request.js:848
    Request.prototype.closed = function closed() {
                             ^

TypeError: Cannot set property closed of #<Readable> which has only a getter
    at patch (/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/request.js:848:30)
    at Object.<anonymous> (/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/server.js:33:1)

Specific Changes

  • Upgraded restify version in Package.json

Testing

Create a echo bot dot following the SDK docs, if you are on Node 18 or above you will run into the following error.

Related PR

restify/node-restify#1906

Current version leads to the following error on Node 18+:

➜  my-echo-bot npm start

> my-echo-bot@1.0.0 start
> node ./index.js

/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/request.js:848
    Request.prototype.closed = function closed() {
                             ^

TypeError: Cannot set property closed of #<Readable> which has only a getter
    at patch (/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/request.js:848:30)
    at Object.<anonymous> (/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/server.js:33:1)
@GregBorrelly GregBorrelly requested a review from a team as a code owner August 6, 2023 03:30
@coveralls
Copy link

coveralls commented Aug 7, 2023

Pull Request Test Coverage Report for Build 5774405781

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.857%

Totals Coverage Status
Change from base Build 5727280167: -0.003%
Covered Lines: 20135
Relevant Lines: 22485

💛 - Coveralls

@ceciliaavila
Copy link
Collaborator

We should update the other templates (empty and core) and the TS versions as well.

@tracyboehrer
Copy link
Member

We should update the other templates (empty and core) and the TS versions as well.

I'll merge this. Can you open an issue to address these other templates?

@tracyboehrer tracyboehrer merged commit 447c81c into microsoft:main Aug 17, 2023
12 of 13 checks passed
@ceciliaavila
Copy link
Collaborator

We should update the other templates (empty and core) and the TS versions as well.

I'll merge this. Can you open an issue to address these other templates?

Issue created: #4520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants