Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6655] Implementation of Teams batch APIs #4527

Closed
7 tasks done
sw-joelmut opened this issue Aug 21, 2023 · 0 comments · Fixed by #4535
Closed
7 tasks done

port: [#6655] Implementation of Teams batch APIs #4527

sw-joelmut opened this issue Aug 21, 2023 · 0 comments · Fixed by #4535
Assignees
@ceciliaavila
Labels
feature-request A request for new functionality or an enhancement to an existing one. parity The issue describes a gap in parity between two or more platforms.

Comments

@sw-joelmut
Copy link
Collaborator

The changes in [#6655] Implementation of Teams batch APIs may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

#minor

Description

This PR implements the new Teams batch APIs in TeamsOperations.

  • Send message to a list of users
  • Send message to all users in a tenant
  • Send message to all users in a team
  • Send message to a list of channels
  • Get Operation State
  • Get failed entries paginated
  • Cancel Operation

Specific Changes

  • Implemented the new methods in TeamsOperations, TeamsOperationsExtensions, and TeamsInfo.
  • Created Microsoft.Bot.Connector/RetryAction class to handle the retry logic of the operations.
  • Added BatchFailedEntriesResponse, BatchFailedEntry, and BatchOperationState classes in Bot.Schema/Teams to handle the operation response types.
  • Added unit test to cover the new methods.

Testing

These images show some of the new operations working.
image
image
@sw-joelmut sw-joelmut added bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms. labels Aug 21, 2023
@ceciliaavila ceciliaavila added feature-request A request for new functionality or an enhancement to an existing one. and removed bug Indicates an unexpected problem or an unintended behavior. labels Aug 25, 2023
@ceciliaavila ceciliaavila mentioned this issue Sep 18, 2023
Merged
tracyboehrer pushed a commit that referenced this issue Oct 3, 2023
@ceciliaavila @JhontSouth
port: [#4527][#6655] Implementation of Teams batch APIs (#4535)
901b06a 
* add teams batch operations

* update teamsInfo logic

* add unit tests for batch operations

* fix retry logic

* apply code feedback

* Fix lint issue

---------

Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
feature-request A request for new functionality or an enhancement to an existing one. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4527][#6655] Implementation of Teams batch APIs microsoft/botbuilder-js
2 participants
@ceciliaavila @sw-joelmut