Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4527][#6655] Implementation of Teams batch APIs #4535

Merged
merged 7 commits into from
Oct 3, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4527

Description

This PR implements the new Teams batch APIs in TeamsOperations.

  • Send message to a list of users
  • Send message to all users in a tenant
  • Send message to all users in a team
  • Send message to a list of channels
  • Get Operation State
  • Get failed entries paginated
  • Cancel Operation

Specific Changes

  • Implemented the new methods in TeamsOperations, TeamsOperationsExtensions, and TeamsInfo.
  • Created botframework-connector/retryAction function to handle the retry logic of the operations.
  • Added batch operations models and mappers in botframework-connector to handle the operation responses and requests.
  • Added unit test to cover the new methods.

Testing

These images show some of the new operations working.
MessageAListOfUsers
GetFailedEntries

@ceciliaavila ceciliaavila requested a review from a team as a code owner September 18, 2023 13:59
@coveralls
Copy link

coveralls commented Sep 18, 2023

Pull Request Test Coverage Report for Build 6394726411

  • 80 of 84 (95.24%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 84.903%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/teamsInfo.ts 35 36 97.22%
libraries/botframework-connector/src/teams/retryAction.ts 12 15 80.0%
Totals Coverage Status
Change from base Build 6394042052: 0.03%
Covered Lines: 20256
Relevant Lines: 22611

💛 - Coveralls

@tracyboehrer
Copy link
Member

@ceciliaavila Can you resolve the conflict?

@ceciliaavila
Copy link
Collaborator Author

@ceciliaavila Can you resolve the conflict?

Conflicts solved @tracyboehrer.

@tracyboehrer tracyboehrer merged commit 901b06a into main Oct 3, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/teams-batch-operations branch October 3, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: [#6655] Implementation of Teams batch APIs
4 participants