Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6685] Update JwtTokenExtractor #4529

Closed
ceciliaavila opened this issue Aug 25, 2023 · 0 comments · Fixed by #4531
Closed

port: [#6685] Update JwtTokenExtractor #4529

ceciliaavila opened this issue Aug 25, 2023 · 0 comments · Fixed by #4531
Assignees
@ceciliaavila
Labels
bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms.

Comments

@ceciliaavila
Copy link
Collaborator

The changes in [#6685] Update JwtTokenExtractor.cs may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

#minor

Description

Use the used signing key's id instead of kid in header to check endorsement
@ceciliaavila ceciliaavila added bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms. labels Aug 25, 2023
@ceciliaavila ceciliaavila self-assigned this Aug 25, 2023
@ceciliaavila ceciliaavila mentioned this issue Sep 5, 2023
Merged
tracyboehrer pushed a commit that referenced this issue Sep 6, 2023
@ceciliaavila @JhontSouth
port: [#4529] Update JwtTokenExtractor (#4531)
afd6b39 
* modify the test to avoid throwing error

* apply sinon changes

---------

Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4529] Update JwtTokenExtractor microsoft/botbuilder-js
1 participant
@ceciliaavila