Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4529] Update JwtTokenExtractor #4531

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4529

Description

This PR fixes the throws exception on expired token test updating the token and avoiding logging an error in the console.

Note: Because the implementation of the token validation between botbuilder-dotnet and botbuilder-js is different, we haven't ported .NET changes, since botbuilder-js uses a cache check as a security method for the token key.

Specific Changes

  • Updated authorization token in throws exception on expired token test.
  • Replaced the use of sinon.spy by sinon.stub in throws exception on expired token test in cloudAdapter.test.

Testing

The following image shows the unit test throws exception on expired token passing without logging error in the console.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner September 5, 2023 19:41
@tracyboehrer tracyboehrer merged commit afd6b39 into main Sep 6, 2023
@tracyboehrer tracyboehrer deleted the southworks/update/jwt-token-extractor branch September 6, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: [#6685] Update JwtTokenExtractor
3 participants