scoreThreshold no longer works in 4.17.0 and later

[dmvtech]

Describe the bug

When supplying scoreThreshold, it is not honored and will return the answer even though the score is much lower.

Versions

4.17.0 and later
Works in 4.16.0

Describe the bug

When supplying scoreThreshold, it is not honored and will return the answer even though the score is much lower.

const qnaOptions = {scoreThreshold:0.65};
const qnaResults = await this.qnaMaker.getAnswers(context,qnaOptions);

To Reproduce

Steps to reproduce the behavior:

1. Use sample such as: https://github.com/microsoft/BotBuilder-Samples/tree/releases/4.16/samples/javascript_nodejs/11.qnamaker
2. Add options to use the scoreThreshold
   const qnaOptions = {scoreThreshold:0.65};
   const qnaResults = await this.qnaMaker.getAnswers(context,qnaOptions);
3. Test with a question that has a score that will not meet the threshold
4. See that you will get a valid answer anyway

Expected behavior

Should give No QnA Maker answers were found. or similar error as the answer is not above the threshold.

Additional context

• .NET SDK does not seem to have the issue.
• Note that we (at least in the JS SDK, do not send a valid scoreThreahold to QnA endpoint. QnA endpoint will use 0-100 for the threshold, and the SDK uses a float 0.0-1 and therefore will almost always hit the QnA threshold. We then filter/compare after the results returned and determine if it is a valid answer.

Somewhat related issue:
#1808

[dmvtech]

@ceciliaavila Let me know if there are any questions. I can reproduce and will try and add some screenshots shortly.

[dmvtech]

In my example;

• The question What are pickles? has a score of 100
• The question Do you know those cucumbers in vinegar? has a score of 46.31
• The scoreThreshold in the bot is set to 0.65

Working as expected in 4.16.0

Failing in 4.17.0

[tracyboehrer]

Possibly related to this: #4208