Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Botbuilder-ai bugs #4208

Merged
merged 5 commits into from
Apr 29, 2022
Merged

fix: Botbuilder-ai bugs #4208

merged 5 commits into from
Apr 29, 2022

Conversation

Arsh-Kashyap
Copy link
Contributor

@Arsh-Kashyap Arsh-Kashyap commented Apr 28, 2022 •
edited
Loading

Fixes #4207
Fixes #4205

Description

  1. Card is formed for every response and check for answerSpan is removed from checkForMultiTurnPrompt in qnamakerDialog to maintain parity with C#.
  2. Sorting and filtering of the answers is removed from generateAnswerUtils

Testing

Updated QnAMaker tests.

@Arsh-Kashyap Arsh-Kashyap changed the title Botbuilder-ai bugs fix: Botbuilder-ai bugs Apr 28, 2022
@ghost
Copy link

ghost commented Apr 29, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@coveralls
Copy link

coveralls commented Apr 29, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2243625499

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 84.48%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai/src/qnaMakerDialog.ts 9 11 81.82%
Totals Coverage Status
Change from base Build 2191296601: -0.002%
Covered Lines: 19902
Relevant Lines: 22310
💛 - Coveralls

@Arsh-Kashyap Arsh-Kashyap marked this pull request as ready for review April 29, 2022 06:37
@Arsh-Kashyap Arsh-Kashyap requested a review from a team as a code owner April 29, 2022 06:37
@tracyboehrer tracyboehrer merged commit bfa6243 into microsoft:main Apr 29, 2022
@tracyboehrer tracyboehrer mentioned this pull request Nov 15, 2023
Closed
@ceciliaavila ceciliaavila mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Arsh-Kashyap @coveralls @tracyboehrer