Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MS Teams tenant ID location needs mapping in BotFrameworkAdapter.createConversation #884

Closed
benbrown opened this issue Apr 22, 2019 · 1 comment · Fixed by #886
Closed

MS Teams tenant ID location needs mapping in BotFrameworkAdapter.createConversation #884

benbrown opened this issue Apr 22, 2019 · 1 comment · Fixed by #886
Assignees
@benbrown
Labels
4.4 April 15, 2019 Release bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker

Comments

@benbrown
Copy link
Contributor

Versions

4.3

Describe the bug

The tenant id of a given MS Teams tenant is currently located in the legacy location of activity.channelData.tenant.id, but we expect it to be in activity.conversation.tenantId.

We need to handle BOTH possible locations until the MS Teams API is updated.

To Reproduce

Using teams, call adapter.createConversation.

An error will occur about missing tenant id.
benbrown added a commit that referenced this issue Apr 22, 2019
@benbrown
Add default middleware to patch location of tenantId for MS Teams (Fixes
fa2f801 
 #884)
@benbrown benbrown mentioned this issue Apr 22, 2019
Merged
@benbrown
Copy link
Contributor Author

Javascript fix: #886

@gabog gabog added 4.4 April 15, 2019 Release P0 Must Fix. Release-blocker labels Apr 22, 2019
@gabog gabog added the bug Indicates an unexpected problem or an unintended behavior. label Apr 22, 2019
@axelsrz axelsrz mentioned this issue Apr 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbrown benbrown

Labels
4.4 April 15, 2019 Release bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add default middleware to patch location of tenantId for MS Teams microsoft/botbuilder-js
2 participants
@benbrown @gabog