-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default middleware to patch location of tenantId for MS Teams #886
Conversation
NOTE: I fixed this with a middleware because it seemed like this was the LEAST disruptive place to put code that will only be needed until the protocol change happens. The other possible place to do this would be inside processActivity, which seemed less good. |
Pull Request Test Coverage Report for Build #2212
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
All of Tom's feedback is taken, and he's busy - so I'm dismissing to Ben can merge once the build is passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #884
Description
This change handles the in-transition locaiton of the tenant ID field for MS Teams.
Specific Changes
Load a middleware in the constructor for BotFrameworkAdapter that will look for channelData.tenant.id and copy the value to conversation.tenantId for use in createConversation.
Testing
adapter.createConversation
to create a DM with a user.