Replace done w/ async part 5 (final PR for this) #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrichardson
commented
Mar 24, 2021
| @@ -134,7 +134,7 @@ export class DialogTestClient { | |||
| * Send an activity into the dialog. | |||
| * | |||
| * ```javascript | |||
| * DialogTest.send('hello').assertReply('hello yourself').then(done); | |||
| * await DialogTest.send('hello').assertReply('hello yourself').startTest(); | |||
There was a problem hiding this comment.
Note: Figured I may as well make the comments show the "right" way.
mdrichardson
commented
Mar 24, 2021
| }); | ||
| it('should fail with invalid conversatoinId', function(done) { | ||
| var params = createConversation(); | ||
| it('should fail with invalid conversationId', async function () { |
There was a problem hiding this comment.
Note: Renaming this test required this file to be renamed, below: Bot_Framework_Connector_SDK_Conversations_GetActivityMembers_should_fail_with_invalid_conversationId.nock.js
mdrichardson
changed the title
Pull Request Test Coverage Report for Build 684548287
💛 - Coveralls |
joshgummersall
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Even though this basically only covers
botbuilder-connector, this is the last PR on this issue and everything that can be easily converted now has been.Fixes #3226
Covers
(Alphabetically such that
botbuildercomes beforebotbuilder-)botbuilder-dialogs-adaptivethrough end, inclusiveExcludes
connector.test.jsbotframework-streaming. Many rely on callbacks and don't work when converted.Description
Replaces the use of
done()in tests with properasync/await.Specific Changes
done=>async/awaitdone(err)