Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace done w/ async part 5 (final PR for this) #3436

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Replace done w/ async part 5 (final PR for this) #3436

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d4dcf9
done to async in tests
Mar 24, 2021
dc3a9fb
no-op formatting fixes
Mar 24, 2021
4d8071d
Merge branch 'main' into doneToAsyncPt5
mdrichardson Mar 24, 2021
d9c5693
Merge branch 'main' into doneToAsyncPt5
mdrichardson Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/botbuilder-testing/src/dialogTestClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export class DialogTestClient {
* Send an activity into the dialog.
*
* ```javascript
* DialogTest.send('hello').assertReply('hello yourself').then(done);
* await DialogTest.send('hello').assertReply('hello yourself').startTest();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Figured I may as well make the comments show the "right" way.

* ```
*
* @param activity an activity potentially with text
Expand Down
Loading