Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#3969] useLanguagePolicy setting turn state, instead of languag… #3973

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Nov 5, 2021

…ePolicy (#3972)

This reverts commit 619ac13.

  • fix: useLanguagePolicy setting turn state, instead of languagePolicy

#minor

…ePolicy (#3972)

* Revert "Revert "port: Register missingProperties custom function to get all variables the template contains (#3885)" (#3970)"

This reverts commit 619ac13.

* fix: useLanguagePolicy setting turn state, instead of languagePolicy
@joshgummersall joshgummersall requested review from stevengum and a team as code owners November 5, 2021 18:52
@coveralls
Copy link

coveralls commented Nov 5, 2021

Pull Request Test Coverage Report for Build 1427012044

  • 69 of 78 (88.46%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 84.59%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/functions/missingPropertiesFunction.ts 12 14 85.71%
libraries/botbuilder-dialogs-adaptive/src/generators/multiLanguageGeneratorBase.ts 40 47 85.11%
Totals Coverage Status
Change from base Build 1422089706: 0.05%
Covered Lines: 19706
Relevant Lines: 22072

💛 - Coveralls

@joshgummersall joshgummersall merged commit b61f335 into 4.15 Nov 5, 2021
@joshgummersall joshgummersall deleted the jpg/4.15 branch November 5, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants