Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MissingProperties custom function has introduced logic that breaks Core Language bot scenarios #3969

Closed
ryanisgrig opened this issue Nov 2, 2021 · 0 comments · Fixed by #3970 or #3972
Closed

MissingProperties custom function has introduced logic that breaks Core Language bot scenarios #3969

ryanisgrig opened this issue Nov 2, 2021 · 0 comments · Fixed by #3970 or #3972
Assignees
@ceciliaavila
Labels
Area: AI-LUIS The issue is related to LUIS bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. P1 Painful if we don't fix, won't block releasing
Milestone
R15

Comments

@ryanisgrig
Copy link

ryanisgrig commented Nov 2, 2021 •
edited
Loading

Versions

What package version of the SDK are you using.
4.15.0-rc0.preview

Describe the bug

Core Language bot is hung when making LUIS calls and is unable to proceed. Something is up with consultation mode when it's invoking child dialogs.

To Reproduce

  1. Create a Core Language (JS) bot in Composer
  2. Update the botbuilder-dialogs-adaptive-runtime-integration-express reference to 4.15.0-rc0.preview

Expected behavior

When saying "help" or "cancel" but should reply as expected, but instead it doesn't respond.

Additional context

Reverting 3e2beae appears to resolve the problem.
@ryanisgrig ryanisgrig added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Nov 2, 2021
@mrivera-ms mrivera-ms added Area: AI-LUIS The issue is related to LUIS P1 Painful if we don't fix, won't block releasing labels Nov 3, 2021
@mrivera-ms mrivera-ms added this to the R15 milestone Nov 3, 2021
@joshgummersall joshgummersall mentioned this issue Nov 3, 2021
Merged
@sw-joelmut sw-joelmut mentioned this issue Nov 4, 2021
Merged
joshgummersall pushed a commit that referenced this issue Nov 5, 2021
@sw-joelmut
fix: [#3969] useLanguagePolicy setting turn state, instead of languag…
98dd347 
…ePolicy (#3972)

* Revert "Revert "port: Register missingProperties custom function to get all variables the template contains (#3885)" (#3970)"

This reverts commit 619ac13.

* fix: useLanguagePolicy setting turn state, instead of languagePolicy
joshgummersall pushed a commit that referenced this issue Nov 5, 2021
@sw-joelmut
fix: [#3969] useLanguagePolicy setting turn state, instead of languag…
83c235b 
…ePolicy (#3972)

* Revert "Revert "port: Register missingProperties custom function to get all variables the template contains (#3885)" (#3970)"

This reverts commit 619ac13.

* fix: useLanguagePolicy setting turn state, instead of languagePolicy
joshgummersall pushed a commit that referenced this issue Nov 5, 2021
@sw-joelmut
fix: [#3969] useLanguagePolicy setting turn state, instead of languag…
b61f335 
…ePolicy (#3972) (#3973)

* Revert "Revert "port: Register missingProperties custom function to get all variables the template contains (#3885)" (#3970)"

This reverts commit 619ac13.

* fix: useLanguagePolicy setting turn state, instead of languagePolicy

Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
joshgummersall pushed a commit that referenced this issue Nov 8, 2021
Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of…
2d09e67 
… languagePolicy (#3972)"

This reverts commit 98dd347.
joshgummersall pushed a commit that referenced this issue Nov 8, 2021
Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of…
a5ae17e 
… languagePolicy (#3972)" (#3976)

This reverts commit 98dd347.
joshgummersall pushed a commit that referenced this issue Nov 8, 2021
Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of…
61f332b 
… languagePolicy (#3972)" (#3976)

This reverts commit 98dd347.
joshgummersall pushed a commit that referenced this issue Nov 8, 2021
Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of…
ed1831b 
… languagePolicy (#3972)" (#3976) (#3977)

This reverts commit 98dd347.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
Area: AI-LUIS The issue is related to LUIS bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. P1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
R15
3 participants
@ryanisgrig @ceciliaavila @mrivera-ms