Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of languagePolicy" #3976

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Nov 8, 2021

#minor

Reverts #3972

Looks like there is still an outstanding issue and this will be reverted in .NET.

@joshgummersall joshgummersall requested review from stevengum and a team as code owners November 8, 2021 18:42
@EricDahlvang EricDahlvang changed the title Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of languagePolicy" #minor Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of languagePolicy" Nov 8, 2021
@EricDahlvang EricDahlvang changed the title #minor Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of languagePolicy" #fix Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of languagePolicy" Nov 8, 2021
@EricDahlvang EricDahlvang changed the title #fix Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of languagePolicy" fix: Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of languagePolicy" Nov 8, 2021
@joshgummersall joshgummersall merged commit a5ae17e into main Nov 8, 2021
@joshgummersall joshgummersall deleted the revert-3972-southworks/fix/language-generator-initial-turnstate branch November 8, 2021 18:57
joshgummersall pushed a commit that referenced this pull request Nov 8, 2021
@coveralls
Copy link

coveralls commented Nov 8, 2021

Pull Request Test Coverage Report for Build 1436204658

  • 20 of 23 (86.96%) changed or added relevant lines in 3 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-7.9%) to 84.54%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/generators/multiLanguageGeneratorBase.ts 17 20 85.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
libraries/botbuilder-dialogs/src/memory/scopes/dialogClassMemoryScope.ts 7 20.83%
Totals Coverage Status
Change from base Build 1427007791: -7.9%
Covered Lines: 19650
Relevant Lines: 22018

💛 - Coveralls

joshgummersall pushed a commit that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants