Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#3969] useLanguagePolicy setting turn state, instead of… #3977

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix: [#3969] useLanguagePolicy setting turn state, instead of… #3977

merged 1 commit into from
Nov 8, 2021

Conversation

joshgummersall
Copy link
Contributor

… languagePolicy (#3972)" (#3976)

This reverts commit 98dd347.

#minor

@joshgummersall joshgummersall requested review from stevengum and a team as code owners November 8, 2021 19:00
@joshgummersall joshgummersall changed the title Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of… fix: [#3969] useLanguagePolicy setting turn state, instead of… Nov 8, 2021
@coveralls
Copy link

coveralls commented Nov 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1436265902

  • 20 of 23 (86.96%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 84.54%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/generators/multiLanguageGeneratorBase.ts 17 20 85.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 2 84.48%
libraries/botbuilder-dialogs/src/memory/scopes/dialogClassMemoryScope.ts 7 20.83%
Totals Coverage Status
Change from base Build 1427088999: -0.05%
Covered Lines: 19650
Relevant Lines: 22018
💛 - Coveralls

@joshgummersall joshgummersall merged commit ed1831b into 4.15 Nov 8, 2021
@joshgummersall joshgummersall deleted the jpg/4.15 branch November 8, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricDahlvang EricDahlvang EricDahlvang approved these changes

@stevengum stevengum Awaiting requested review from stevengum

@luhan2017 luhan2017 Awaiting requested review from luhan2017 luhan2017 was automatically assigned from microsoft/bf-adaptive

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgummersall @coveralls @EricDahlvang