Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4204] Fix remaining eslint warnings - botbuilder-core (1/2) #4228

Merged
merged 5 commits into from
Jun 16, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4204
#minor

Description

This PR fixes the ESLint and JSDoc issues in the botbuilder-core library.

Note: we excluded the @typescript-eslint/no-explicit-any and @typescript-eslint/explicit-module-boundary-types to tackle those issues as a separate task as they require deeper analysis and testing.

Specific Changes

  • Applied auto-fixes with yarn lint --fix
    • Add trailing commas.
    • Fix spacing.
    • Fix indentation.
    • Add blank line in between comments.
    • Fix quoting.
    • Replace let with const.
  • Applied manual fixes for:
    • Missing documentation.
    • Unused parameters and imports.
    • Replacing hasOwnProperty calls.
    • Changing obsolete tags with deprecated.
  • Removed unused lodash devDependency.
  • Updated methods documentation in botbuilder-core.api.md.

Testing

Here we can see the eslint status before and after.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner May 2, 2022 14:39
@coveralls
Copy link

coveralls commented May 2, 2022

Pull Request Test Coverage Report for Build 2510072684

  • 25 of 25 (100.0%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 84.479%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-core/src/activityHandler.ts 1 90.27%
Totals Coverage Status
Change from base Build 2509499383: -0.2%
Covered Lines: 19904
Relevant Lines: 22312

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit a4f3bf9 into main Jun 16, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botbuilder-core-1 branch June 16, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants