Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining eslint warnings #4204

Closed
ceciliaavila opened this issue Apr 25, 2022 · 0 comments · Fixed by #4241
Closed

Fix remaining eslint warnings #4204

ceciliaavila opened this issue Apr 25, 2022 · 0 comments · Fixed by #4241
Assignees
@JuanAr
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@ceciliaavila
Copy link
Collaborator

Description

There are still eslint warnings to solve in several libraries in order to treat the violations as errors in CI.
This is the current status:
image

Proposed solution

Fix all the remaining warnings in the different libraries and update the .eslintrc.json file to prevent new issues to be introduced.
@ceciliaavila ceciliaavila added needs-triage The issue has just been created and it has not been reviewed by the team. feature-request A request for new functionality or an enhancement to an existing one. labels Apr 25, 2022
This was referenced May 2, 2022
Merged
Merged
Merged
This was referenced May 2, 2022
Closed
Closed
Closed
This was referenced May 4, 2022
Merged
Merged
@sw-joelmut sw-joelmut mentioned this issue May 5, 2022
Merged
This was referenced May 12, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
tracyboehrer pushed a commit that referenced this issue Jun 15, 2022
@sw-joelmut
fix: [#4204] Fix remaining eslint warnings - final issues (#4240)
4b1be03 
* Warnings fixed in botbuilder-ai-orchestrator

* Warnings in botbuilder fixed.

* Warnings fixed in adaptive-expressions

* Warnings fixed in botframework-connector

* Suggested changes applied.

* Documentation updated

* Additional warning fixed.

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
tracyboehrer added a commit that referenced this issue Jun 16, 2022
@ceciliaavila @tracyboehrer
fix: [#4204] Fix remaining eslint warnings - botbuilder-core (1/2) (#…
a4f3bf9 
…4228)

* Fix eslint issues in botbuilder-core (1/2)

* Fix depcheck error

* Corrected conflict resolution error

* Fixed accessor conflict

Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com>
Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>
tracyboehrer pushed a commit that referenced this issue Jul 12, 2022
@ceciliaavila
fix: [#4204] Fix remaining eslint warnings - botbuilder-dialogs-adapt…
7cfb39a 
…ive (#4230)

* Fix eslint issues in botbuilder-dialogs-adaptive

* Fix spacing
tracyboehrer pushed a commit that referenced this issue Jul 13, 2022
@ceciliaavila
fix: [#4204] Fix remaining eslint warnings - botbuilder-dialogs (1/2) (…
68f49ba 
…#4231)

* Fix eslint issues in botbuilder-dialogs (1/2)

* Fix comments
tracyboehrer pushed a commit that referenced this issue Jul 13, 2022
@ceciliaavila
fix: [#4204] Fix remaining eslint warnings - botbuilder-dialogs (2/2) (…
134d367 
…#4232)

* Fix eslint issues in botbuilder-dialogs (2/2)

* Update botbuilder-dialogs.api doc
tracyboehrer pushed a commit that referenced this issue Jul 13, 2022
@sw-joelmut @ceciliaavila
fix: [#4204] Fix remaining eslint warnings - Rest of botbuilder-dialo…
0305b7d 
…gs libraries - botbuilder adaptive testing (#4237)

* Warnings fixed. Missing documentation, unused parameters and imports, disabling detect-non-literal-fs-filename rule and no-constant-condition rule.

* Void changes removed. Unknown type restored to Any. Documentation added.

* api.md file moved to etc folder

* Suggested changes applied.

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
tracyboehrer pushed a commit that referenced this issue Jul 13, 2022
@sw-joelmut @ceciliaavila
fix: [#4204] Fix remaining eslint warnings - botframework-config (#4234)
8ec3563 
* Fix eslint issues in botframework-config

* Update botframework-config compat

Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
tracyboehrer pushed a commit that referenced this issue Jul 13, 2022
@sw-joelmut @ceciliaavila
fix: [#4204] Fix remaining eslint warnings - botbuilder-lg (#4235)
5c1d429 
* Fix eslint issues in botbuilder-lg

* Update botbuilder-lg compat

* Fix EvaluationOptions nullSubstitution

* Missing dots.

* Revert "Update botbuilder-lg compat"

This reverts commit 2c88f64.

* Add missing documentation for the Templates class

* Uppercase instead of lowercase in method definitions.

* ammend

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
tracyboehrer pushed a commit that referenced this issue Jul 13, 2022
@sw-joelmut
fix: [#4204] Fix remaining eslint warnings - botbuilder-ai (#4236)
0148107 
* Fix eslint issues in botbuilder-ai

* Update botbuilder-ai compat

* Fix eslint disable rule

* ammend

* Revert "Fix eslint disable rule"

This reverts commit 36bef89.

* Commit reverted.

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
tracyboehrer pushed a commit that referenced this issue Jul 13, 2022
@sw-joelmut @ceciliaavila
fix: [#4204] Fix remaining eslint warnings - Rest of botbuilder-dialo…
bc668f6 
…gs libraries - botbuilder declarative (#4238)

* Automatic and manual fixes. Fs.readFileSync dynamic path, missing documentation.

* Documentation improvements.

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
tracyboehrer pushed a commit that referenced this issue Jul 13, 2022
@sw-joelmut
fix: [#4204] Fix remaining eslint warnings - Rest of botbuilder-dialo…
a8d076e 
…gs libraries - adaptive runtime (#4239)

* Warnings fixed. Missing documentation.

* Minor documentation changes

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
@ceciliaavila ceciliaavila mentioned this issue Jul 14, 2022
Merged
tracyboehrer pushed a commit that referenced this issue Jul 19, 2022
@sw-joelmut @ceciliaavila
fix: [#4204] Fix remaining eslint warnings - enable ESLint config (#4241
57e2642 
)

* Update eslint config

* Update lint script to fail if there is a warning

Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
Co-authored-by: CeciliaAvila <cecilia.avila@southworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [#4204] Fix remaining eslint warnings - enable ESLint config microsoft/botbuilder-js
2 participants
@JuanAr @ceciliaavila