Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4204] Fix remaining eslint warnings - botbuilder-dialogs (1/2) #4231

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4204
#minor

Description

This PR fixes the ESLint and JSDoc issues in the botbuilder-dialogs library.

Note: we excluded the @typescript-eslint/no-explicit-any and @typescript-eslint/explicit-module-boundary-types to tackle those issues as a separate task as they require deeper analysis and testing.

Specific Changes

  • Applied auto-fixes with yarn lint --fix
    • Add trailing commas.
    • Fix spacing.
    • Fix indentation.
    • Add blank line in between comments.
    • Fix quoting.
  • Applied manual fixes for:
    • Missing documentation.
    • Unused parameters and imports.
    • Replacing hasOwnProperty calls.
    • Changing obsolete tags with deprecated.
    • Using template tag to document generic types.
    • Disabling detect-non-literal-fs-filename rule to allow dynamic path for files.
    • Disabling no-constant-condition rule to allow while(true) loop.
    • Fixing lodash imports.
  • Added uuid as dependency (excluding it from the .depcheckrc as it incorrectly marks it as unused).
  • Updated methods documentation in botbuilder-dialogs.api.md.

Testing

Here we can see the eslint status before and after.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner May 4, 2022 20:35
@coveralls
Copy link

coveralls commented May 4, 2022

Pull Request Test Coverage Report for Build 2665212552

  • 13 of 18 (72.22%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.479%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs/src/dialog.ts 0 1 0.0%
libraries/botbuilder-dialogs/src/memory/scopes/botStateMemoryScope.ts 0 1 0.0%
libraries/botbuilder-dialogs/src/memory/scopes/dialogMemoryScope.ts 1 2 50.0%
libraries/botbuilder-dialogs/src/dialogManager.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 2656737347: -0.003%
Covered Lines: 19904
Relevant Lines: 22312

💛 - Coveralls

@ceciliaavila ceciliaavila force-pushed the southworks/fix/eslint-botbuilder-dialogs branch from 0948b83 to b432f54 Compare July 13, 2022 14:50
@ceciliaavila ceciliaavila force-pushed the southworks/fix/eslint-botbuilder-dialogs branch from 93b366b to 58c77d8 Compare July 13, 2022 17:34
@tracyboehrer tracyboehrer merged commit 68f49ba into main Jul 13, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botbuilder-dialogs branch July 13, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants