Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4204] Fix remaining eslint warnings - Rest of botbuilder-dialogs libraries - botbuilder adaptive testing #4237

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4204
#minor

Description

This PR fixes the ESLint and JSDoc issues in the botbuilder-dialogs-adaptive-testing library.

Specific Changes

  • Applied auto-fixes with yarn lint --fix
    • Fix spacing
    • Fix indentation
    • Add blank line in between comments
    • Fix quoting
    • Add trailing commas
  • Applied manual fixes for:
    • Missing documentation.
    • Unused parameters and imports
    • Disabling detect-non-literal-fs-filename rule to allow dynamic path for files
    • Disabling no-constant-condition rule to allow while (true) loop

Testing

Eslint and tests status

image

image

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 12, 2022 16:38
@coveralls
Copy link

coveralls commented May 12, 2022

Pull Request Test Coverage Report for Build 2656902873

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.479%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive-testing/src/dialogInspector.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 2656737347: -0.003%
Covered Lines: 19904
Relevant Lines: 22312

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 0305b7d into main Jul 13, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-rest-of-botbuilder-dialogs-adaptive-testing branch July 13, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants