Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4204] Fix remaining eslint warnings - remaining issues #4281

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4204
#minor

Description

This PR fixes the new ESLint and JSDoc issues introduced before enabling lint check.

Specific Changes

  • Applied auto-fixes with yarn lint --fix
    • Fix indentation
  • Applied manual fixes for:
    • Missing documentation in the appCredentials class.

Testing

Here we can see the yarn lint command running without issues.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner July 14, 2022 17:28
@coveralls
Copy link

coveralls commented Jul 14, 2022

Pull Request Test Coverage Report for Build 2672032686

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 84.483%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-core/src/testAdapter.ts 1 89.68%
Totals Coverage Status
Change from base Build 2665681549: -0.004%
Covered Lines: 19900
Relevant Lines: 22308

💛 - Coveralls

@ceciliaavila
Copy link
Collaborator Author

Hi @tracyboehrer, here is the fix for the new lint issues. After merging this PR, the checks on #4241 should pass.

@tracyboehrer tracyboehrer merged commit 3b6dc83 into main Jul 15, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/remaining-eslint-issues branch July 15, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants