fix: [#4204] Fix remaining eslint warnings - enable ESLint config #4241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4204
Description
This PR updates the ESLint configuration adding new rules and disabling the ones regarding the
any
type, since it requires deeper analysis to not use the type. Moreover, we force thelint
script to fail if there is at least one warning, preventing to introduce new ones in the future.Specific Changes
.eslintrc.json
node: true
to theenv
property, due to not recognizing multiple NodeJs types.@typescript-eslint/no-explicit-any
,@typescript-eslint/explicit-module-boundary-types
and@typescript-eslint/ban-types
, since there are many part of the source code that uses implicit or explicitany
types, which requires deeper analysis to decide which type should use instead.jsdoc/require-jsdoc
rule to warn the user when JSDocs are not provided in public classes, methods, properties and functions (ignoring private and protected).Testing
The following images show the configuration working when there are/aren't errors.