Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry Middleware #812

Closed
wants to merge 4 commits into from
Closed

Telemetry Middleware #812

wants to merge 4 commits into from

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Mar 12, 2019

C# Equivalent: microsoft/botbuilder-dotnet#1420

Middlware component that uses BotTelemetryClient to log events when messages are received/sent/updated or deleted in the bot.

Additional Details
https://github.com/daveta/analytics/blob/master/telemetry_enhancements/TelemetryEnhancements.md

@coveralls
Copy link

coveralls commented Mar 12, 2019

Pull Request Test Coverage Report for Build #2061

  • 96 of 102 (94.12%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 87.453%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-core/src/telemetryLoggerMiddleware.ts 81 87 93.1%
Totals Coverage Status
Change from base Build #2041: -0.07%
Covered Lines: 3102
Relevant Lines: 3408

💛 - Coveralls

@daveta
Copy link
Contributor Author

daveta commented Mar 14, 2019

Merging this with #816

@daveta daveta closed this Mar 14, 2019
@daveta daveta deleted the daveta-telemetry-middleware branch March 19, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants