Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry LuisRecognizer & Telemetry Middleware #816

Merged
merged 9 commits into from
Mar 18, 2019
Merged

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Mar 14, 2019

Adds support for BotTelemetryClient (no new dependencies) within the Luis Recognizer & add Telemetry Middleware

(Note: This incorporates @ryanlengel input from microsoft/botbuilder-dotnet#1430).

https://github.com/daveta/analytics/blob/master/telemetry_enhancements/TelemetryEnhancements.md#telemetry-support-luis

Properties can be added to the telemetry event per invocation
Class can be derived to override default behavior
Exposed methods to help populate events when deriving

(Corresponding C# side: microsoft/botbuilder-dotnet#1424)

@coveralls
Copy link

coveralls commented Mar 14, 2019

Pull Request Test Coverage Report for Build #2103

  • 138 of 145 (95.17%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 87.574%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai/src/luisRecognizer.ts 31 32 96.88%
libraries/botbuilder-core/src/telemetryLoggerMiddleware.ts 81 87 93.1%
Totals Coverage Status
Change from base Build #2101: 0.009%
Covered Lines: 3189
Relevant Lines: 3498

💛 - Coveralls

@daveta daveta changed the title Telemetry LuisRecognizer Telemetry LuisRecognizer & Telemetry Middleware Mar 14, 2019
@daveta daveta mentioned this pull request Mar 14, 2019
@daveta
Copy link
Contributor Author

daveta commented Mar 17, 2019

Hi @ryanlengel / @johnataylor - can you take a look?

@daveta daveta requested a review from benbrown March 18, 2019 20:24
@daveta daveta merged commit 620fb62 into master Mar 18, 2019
@daveta daveta deleted the daveta-telemetry-luis branch March 19, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants