Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build break #922

Merged
merged 2 commits into from
May 14, 2019
Merged

Fixed build break #922

merged 2 commits into from
May 14, 2019

Conversation

Stevenic
Copy link
Contributor

Fixes #916

Description

Autorest introduced a breaking change to their credentials interface. We're hitting this at build time because lerna hoists all packages to the root and we can only have one version of autorest from a build perspective.

Specific Changes

I casted the credentials to any just to get things to build. This shouldn't be an issue at runtime so no patch is needed.

@Stevenic Stevenic requested a review from stevengum May 10, 2019 21:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build #2260

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.745%

Totals Coverage Status
Change from base Build #2252: 0.0%
Covered Lines: 3260
Relevant Lines: 3666

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for an autorest-generated problem? :shipit:

@stevengum
Copy link
Member

Taking this fix as the latest version of @azure/ms-rest-js is now 1.8.6, there is no changelog for the package, and the other two PRs that bumped the version are now failing (probably due to 1.8.6 being released).

@stevengum stevengum merged commit 1d20145 into master May 14, 2019
@stevengum stevengum deleted the stevenic/botbuilder-ai-fix branch May 14, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BotBuilder-AI] build failing
4 participants