Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BotBuilder-AI] Update @azure/ms-rest-js to version 1.8.4 #917

Closed
wants to merge 2 commits into from

Conversation

ParadoxARG
Copy link
Contributor

Fixes #916

Description

Update @azure/ms-rest-js library in botbuilder-ai from version 1.8.2 to 1.8.4(latest). This is a required change because the @azure/cognitiveservices-luis-runtime library is using this version and they are not compatible.

We would also suggest changing the package version from ~1.8.4(1.8.x) to ^1.8.4(1.x) to provide the same compatibility as @azure/cognitiveservices-luis-runtime. If we don't we may have issues if a new minor version is released. Also, we should remove @azure/ms-rest-js from the package-lock.json cause with every patch release the build may break, as @azure/cognitiveservices-luis-runtime is always updating to the last version.

Specific Changes

  • change package.json to use @azure/ms-rest-js ~1.8.4

Testing

Build passing:
image

Tests passing:
image

@ParadoxARG ParadoxARG changed the title [BotBuilder-AI] Update ms-rest-js to @azure/ms-rest-js [BotBuilder-AI] Update @azure/ms-rest-js to version 1.8.4 May 8, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build #2257

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 85.692%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build #2252: -0.05%
Covered Lines: 3258
Relevant Lines: 3666

💛 - Coveralls

@stevengum
Copy link
Member

Closing in favor of #922.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BotBuilder-AI] build failing
4 participants