[BotBuilder-AI] Update @azure/ms-rest-js to version 1.8.4 #917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #916
Description
Update
@azure/ms-rest-js
library inbotbuilder-ai
from version1.8.2
to1.8.4
(latest). This is a required change because the@azure/cognitiveservices-luis-runtime
library is using this version and they are not compatible.We would also suggest changing the package version from
~1.8.4
(1.8.x) to^1.8.4
(1.x) to provide the same compatibility as@azure/cognitiveservices-luis-runtime
. If we don't we may have issues if a new minor version is released. Also, we should remove@azure/ms-rest-js
from thepackage-lock.json
cause with every patch release the build may break, as@azure/cognitiveservices-luis-runtime
is always updating to the last version.Specific Changes
~1.8.4
Testing
Build passing:
Tests passing: