Update ms-rest-js to @azure/ms-rest-js #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasper-az
reviewed
May 8, 2019
There was a problem hiding this comment.
In addition to the requested changes/questions regarding the package.json, can you provide some links regarding the dependencies of @azure/cognitiveservices-luis-runtime?
Also, have you tested this change in both browser and node environments? This is because of the @azure/ms-rest-js package works in both environments (info).
ParadoxARG
force-pushed
the
fix/azure-ms-rest-js
branch
from
4158d9a to
2348b94
Compare
|
Replaced by #917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
Description
Update
@azure/ms-rest-jslibrary inbotbuilder-aifrom version1.8.2to1.8.4(latest). This is a required change because the@azure/cognitiveservices-luis-runtimelibrary is using this version and they are not compatible.We would also suggest changing the package version from
~1.8.4(1.8.x) to^1.8.4(1.x) to provide the same compatibility as@azure/cognitiveservices-luis-runtime. If we don't we may have issues if a new minor version is released. Also, we should remove@azure/ms-rest-jsfrom thepackage-lock.jsoncause with every patch release the build may break, as@azure/cognitiveservices-luis-runtimeis always updating to the last version.Specific Changes
1.8.4Testing
Build passing:
Tests passing:
