-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ligatures variants need more explanation #583
Comments
|
Cascadia Code has ligatures by default and doesn't need any switch. Cascadia Mono is for terminals and doesn't use ligatures. Besides according to the docs |
Check again ;) Do you even have latest version 2110.31 or just the default that comes bundled with Windows Terminal or VSCode? I'm using Cascadia Code PL in VSCode so all ligatures are enabled by default. |
|
I know. Already fixed my answer couple minutes before your comment 😛 As you can see all ligatures are still there even without
Wrong! Any string here enables ligatures because it represents So let me ask again @kenmcd @Ionaru : do you have last version of the font installed? |
I am not seeing this. |
If you have an issue with how the font configuration works in VS Code, Regarding your original question, the stylistic sets which do exist in these fonts are documented on the page you linked to. |
It's not an issue with VSCode and it's not even an issue with the font itselft, because it all works as expected. It's an issue with documentation which provides unclear/invalid examples of font configuration. Wasn't I clear on that in opening comment and issue template used? |
I see there has been some 'lively' discussion on this thread. And I'm glad you all figured out that My apologies that the documentation is not quite clear enough—given that the primarily user-defined features are all stylistic sets, I thought that providing guidance about those features (as seen in the image in the README) would be sufficient. And it seems that the sample I pulled from the VSCode repro was confusing. I'll get around to updating the documentation at some point, but if any of y'all would like to help out, please feel free to submit a PR! Regarding use of When I wrote the documentation, writing VSCode version: If that is indeed a change in behavior, then use of |
I would gladly make a PR, but that's the whole problem it's not clear which of the values used in description are actually related to and still valid for Cascadia Code, not FiraCode. Can you check again opening comment and confirm which of these are valid? BTW.
How do you set calt or any other set to off? I thought simply not using it in BTW2. |
The full set of features described in the font is shown in the source folder under features: https://github.com/microsoft/cascadia-code/tree/main/sources/features However, most of these are functionality either required for aspects of the font to work seamlessly, or are not items that I would expect users want to turn on at all times. As I said, the only items that I expect users to want to enable globally are the stylistic sets which are already listed in the README.
See microsoft/vscode#124718
No idea. I don’t believe so.
The behavior has nothing to do with the font. It is entirely how VSCode has implemented things. |
Stylistic sets are embedded into font itself so how is that not relevant? |
I don’t understand your question. |
It's the font that provides stylistic sets, VSCode can only enable them. I'd say it's all about the font. You say it has nothing to do with the font. Care to explain why is that? #402 Looks like but it still doesn't seem to impact cursive in any way. With |
Your inherent misunderstanding is that the coding ligatures are present in The actual impact of each stylistic set is documented in this image, from the README
It appears to me as well that it is enabled by default (it wasn't previously). But that may also be OS-related. I'll need to check VSCode on other systems to confirm the behavior. The fact that @kenmcd and @Ionaru need |
Not at all. It was my understaning from the start that
I understand now that
That's also clear from the begining. What's unclear is the use of FiraCode example with sets that clearly are not available in Cascadia Code so imho using such example is pointless. Unless of course CC does have Fira Code on the other hand is quite clear with their examples. Everything mentioned in the docs is there on the font: |
That code was provided as an example of how to request font features. That's it. |
I think examples valid for Cascadia Code would be much more appreciated. |
@Krysl that's probably because Windows Terminal uses font embeded within the installation as you can see in the paths. It's not Cascadia font installed on your system and most likely not even the same version. Besides this issue is all about this settings being invalid for Cascadia Code as it was simply copy/pasted from Fira Code repository. I can see readme has been updated already with valid description, but it still contains this invalid example. Why? 🤦♂️ It's pretty obvious most users will simply take this invalid example and then wonder why is it not working or what these seetings not mentioned in the description even mean. |
But what does that example, relevant only to Fira Code, have to do with Cascadia documentation, where it is irrelevant, other than puzzling and baffling people? |
For me, I came here to find out what does that mysterious |
Is it possible to only enable cursive without the symbol ? |
To summarize this thread, the README contains the following:
However many of these stylistic sets do not exist for Cascadia Code (chiefly |
Docs could use more valid examples for available ligatures variants. So far I see 'ss01' (this alone enables cursive alternative so what does 'calt' actually do?), 'ss02', 'ss03', 'ss19' (seems like it has the same effect as 'zero') and 'ss20'. Next part of the Readme looks like a copy-paste from FiraCode respository: it links there and has their example:
What does 'ss04', 'ss05', 'ss06' and 'onum' do in Cascadia font? 'onum' in FiraCode changes digits' vertical alignment, but it doesn't look like it works here. I don't see other mentioned stylistic sets in Cascadia Code or Cascadia Mono details:
A lot of confusion here. It should be explained precisely like for FiraCode
The text was updated successfully, but these errors were encountered: