Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

February 2021 update #402

Merged
merged 86 commits into from
Feb 9, 2021
Merged

February 2021 update #402

merged 86 commits into from
Feb 9, 2021

Conversation

aaronbell
Copy link
Collaborator

@aaronbell aaronbell commented Feb 3, 2021

This is a significant update to Cascadia Code including a large number
of bug fixes as well as updating the font to offer support for Fira
Code v5 ligature support.

This update supersedes PR #373.

Closes #262 - ⏎ added
Closes #264 - additional codepoints for control characters added
Closes #281 - !: and !. added
Closes #290 - /\ and \/ added
Closes #301 - ??= added
Closes #324 - ℞ added
Closes #327 - <:> and other variants implemented via the calt
refactoring
Closes #359 - house added
Closes #371 - Added x-height instruction into ttfautohint to control the
height of the lowercase.
Closes #375 - Completely redesigned quote marks for better recognition
Closes #377 - updated hinting to achieve more consistent results
Closes #381 - increased height of thetamod
Closes #382 - reduced the width of the hooklefts
Closes #383 - updated heights on esh, glottalstop, glottalstopreversed
Closes #384 - tweaked hinting a little bit. Maybe it'll help :)
Closes #386 - added remaining soft-dotting
Closes #392 - changed designs of angled quotes (they are now round)
Closes #394 - changed former ~= symbol to a simpler component-based
version. Should be less confusing now for Lua / Matlab users.
Closes #395 - makes the underline thicker based on font weight
Closes #400 - increased size of degree

Closes #219
The full control pictures block has been added (u+2400 to u+2426). For
purposes of rendering, the two letter abbreviations have been used
instead of the standard three letter abbreviations:

Additionally, ss20 includes the oft-unused graphical representations of
these codepoints (for fun!):

Closes #276 (infinite arrows)
Full support for Fira Code's current ligature set (with a few
exceptions). Now featuring infinite arrows!!!

This involved a full refactoring of the calt feature—for those
interested, it now uses forward-looking substitutions instead of
backward-looking substitutions and progressive substitution to reduce
code. This also required some redesigning of the greater / lesser
related ligatures. Please note, I have also removed all the obsolete
ligatures now covered by the arrows code.

Closes #329
There was a mismatch in the font's postscript naming conventions that
was corrected. Should now render all weights in Word. Note there is
apparently an additional bug in Mac Word's implementation of variable
fonts which should be available in an update mid-Feb.

  • Not listed – Reworked the hints for the mod and superscript glyphs so
    that they're bottom-up rather than top-down. This allows for better
    bottom alignments.

Aside from the above changes, this version also includes many other
small updates including spacing, outline quality improvements, and
fixing hinting.

aaronbell and others added 30 commits June 29, 2020 17:15
Decreased Bold weight, added anchors to lowercase Greek, updated GDEF feature builder. Added font linking to STAT.
Reduced weight of bold extreme for better alignment with Regular. Resolved some introduced bugs in hinting and glyph widths.
This reverts commit 25dc61a.
Updating code for the build process and adding in a separate hinting file for the PL glyphs.
Updates build script to include madig's modifications, plus adds static TTF export and autohinting using ttfautohint (if available). Also updated / renamed the Nerdfonts PL file.
- Adjusted box drawing characters for better alignment to the letters
- Added anchors to all alphabetic characters (also brevecomb-cy which was missing them)
- added a fi and fl ligature (and decompose them so they never show up :) )
- improved weight of horncomb (lowercase) in bold
Changing contour order for Extralight to resolve interpolation error
1) Added support for Salishan language groups
2) Remastered mark positioning for glyphs with 2 diacritics (needed for Salishan)
3) Rebuild Build Script to simplify code
4) Fixed minor other hinting issues
5) Fixed RVRN substitutions for heavy weight
Also it wants to update the hyphen glyph, but I don't see any specific changes.
Re-adding the static folder
@DHowett
Copy link
Member

DHowett commented Feb 3, 2021

(I'm concerned about the conflicts in the .fea files from other updates -- looks like there's something missing in this PR?)

@aaronbell
Copy link
Collaborator Author

What do the non-smart quotes look like? Boring old U+0022 and U+0027?

Yup. Boring old. No need to change those fellows!

@aaronbell
Copy link
Collaborator Author

(I'm concerned about the conflicts in the .fea files from other updates -- looks like there's something missing in this PR?)

I took a look at the feature code and, aside from the massive restructuring of the calt feature, everything else looks pretty similar. Is there something you're particularly concerned about?

@DHowett
Copy link
Member

DHowett commented Feb 3, 2021

(I'm concerned about the conflicts in the .fea files from other updates -- looks like there's something missing in this PR?)

I took a look at the feature code and, aside from the massive restructuring of the calt feature, everything else looks pretty similar. Is there something you're particularly concerned about?

Nope, just the worry every time I see a conflict 😄 Thanks!

@aaronbell aaronbell marked this pull request as ready for review February 4, 2021 21:24
@aaronbell
Copy link
Collaborator Author

Alright, I think this is ready to go for this release.

@schuelermine
Copy link

Oooh, I'm excited to download this!

Removed all of the obsolete ligatures now covered by infinite arrows
Corrected some interpolation errors
Added a missing OT feature
Corrected some omissions in the original FiraCode arrows OT features
@DHowett
Copy link
Member

DHowett commented Feb 8, 2021

image

It's our intent that all runs of straight lines ligate now, right? Neat!

@aaronbell
Copy link
Collaborator Author

Yup! So you can make infinitely long arrows or other bits. Try out using > | or < in conjunction :)

@DHowett
Copy link
Member

DHowett commented Feb 9, 2021

In that case, let's do it!. I'll merge.

@DHowett
Copy link
Member

DHowett commented Feb 9, 2021

Screen Shot 2021-02-02 at 3 24 00 PM

Screen Shot 2021-02-02 at 3 24 05 PM

Screen Shot 2021-02-02 at 3 33 54 PM

Screen Shot 2021-02-02 at 3 35 37 PM

Screen Shot 2021-02-02 at 3 40 39 PM

Screen Shot 2021-02-02 at 3 41 52 PM

Screen Shot 2021-02-02 at 3 43 09 PM

Screen Shot 2021-02-02 at 3 44 41 PM

Screen Shot 2021-02-02 at 3 50 01 PM

Screen Shot 2021-02-02 at 3 47 53 PM

Screen Shot 2021-02-02 at 4 06 07 PM

Screen Shot 2021-02-02 at 3 54 18 PM

@DHowett DHowett merged commit 00f3fd4 into microsoft:main Feb 9, 2021
@aaronbell
Copy link
Collaborator Author

the joy of closing 23 bugs

@DHowett
Copy link
Member

DHowett commented Feb 9, 2021

Well done! Thanks for all the excellent, gorgeous fixes. I've got it in build now, and I'll kick the tires a bit before including it in Terminal's upcoming bugfix releases :)

@DHowett
Copy link
Member

DHowett commented Feb 9, 2021

image

This may throw some people off, but I do get why it is the way it is!

@aaronbell
Copy link
Collaborator Author

Yeah, understandable. This is following Fira Code, though, which has had this sort of set up for a while. So if folks aren’t angry over there, I’m ok with it

@schuelermine
Copy link

Is this going to be released as a GitHub release? The last one is from September last year.

@DHowett
Copy link
Member

DHowett commented Feb 10, 2021

@schuelermine no we were going to force every person to compile the font from source for the rest of eternity

yes, of course we're going to release it as a GitHub release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment