Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all history in ccf-app-samples repo #43

Closed
ross-p-smith opened this issue Nov 16, 2022 · 10 comments
Closed

Remove all history in ccf-app-samples repo #43

ross-p-smith opened this issue Nov 16, 2022 · 10 comments
Assignees

Comments

@ross-p-smith
Copy link
Contributor

The https://github.com/microsoft/ccf-app-samples/ repository has previously had certificates stored inside it for the demo. These were replaced by dynamically creating the certificates as part of the demo.

However this means the certs are in the git history and this means it is problematic to fork this repository to Azure DevOps.

I think we should squash the commits before and after the certs being added now before we iterate further.

@takuro-sato takuro-sato self-assigned this Nov 17, 2022
takuro-sato added a commit to takuro-sato/ccf-app-samples that referenced this issue Nov 17, 2022
Some PRs were squashed due to microsoft#43

Copy banking-app from https://github.com/takuro-sato/ccf-app-template/tree/example_apps (microsoft#7)

The repo was originally forked from https://github.com/microsoft/ccf-app-template

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Remove unused codes (microsoft#9)

* Remove unused codes

* Fix failed CI

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Update README.md (microsoft#10)

* Update README.md

* Fix README.md

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Update why ccf + Implement application claim for transfer (microsoft#12)

* Add 'why ccf' section

* Add application claim for transfer API

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Add 'Get claim' endpoint

* Update /receipt so that the response includes the expanded claim

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Remove /claim

Co-authored-by: Takuro Sato <takurosato@microsoft.com>
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

Clean up (microsoft#13)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Add features to devcontainer (microsoft#16)

* Add features to devcontainer

* npm install at container creation

Run tests in CI with virtual mode (microsoft#19)

* Run tests in CI

* Tidy up

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Added guidelines for running tests (microsoft#21)

Add linting (microsoft#20)

* Add linting

* Fix 'detected dubious ownership in repository' error

* See if CI fails as expected

* Revert "See if CI fails as expected"

This reverts commit 4570982.

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Add back 'Open in GitHub Codespaces' button (microsoft#22)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Use docker image that can use virtual (microsoft#25)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Create the user certs as part of the demo (microsoft#34)

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

GitHub Collaboration (microsoft#36)

* Added guide about board

* Typos

Added make file to hide scripts (microsoft#31)

* Add simple make commands

* Add initial devcontainer build

* Adding workflow-dispatch to test

* workflow_dispatch

* Add Safe Directory

* Pass GITHUB_WORKSPACE environment variable

* Added image that can use virtual

* Makefile per sample

* Amended CI

* Removed the banking-app clean from the root

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

Created set_js_app.json for governance (microsoft#33)

Split demo.sh into demo_governance.sh and demo_application.sh (microsoft#40)

* Split demo.sh into demo_governance.sh and demo_application.sh

* add more comments

* remove the extra echo line

* resolve review comments
@takuro-sato
Copy link
Contributor

@ross-p-smith
I force pushed the squashed history to main.
Could you check if you can fork it now?

@ross-p-smith
Copy link
Contributor Author

Same thing -
image

@ross-p-smith
Copy link
Contributor Author

@ross-p-smith
Copy link
Contributor Author

We could try

  • create temporary orphan branch e.g. main-temp
  • do PR from main to main-temp with squash
  • rename main to main-old
  • rename main-temp to main
  • delete all other branches

@takuro-sato
Copy link
Contributor

Both of the link and the way suggested sound good to try.
Before I actually try, could you tell me how I can reproduce the error so that I can do quick try and error?

I tried:

  • Create an Azure DevOps project
  • Use "Import repository" for current main of ccf-app-samples in GitHub.

But I could simply import it. Do I need some setting?

@ross-p-smith
Copy link
Contributor Author

Maybe it's an AzureDevOps linked to the MSFT tenant as credscan is setup on it. I've just tried it again and it fails. Was the Azure DevOps that you created a personal one?

@takuro-sato
Copy link
Contributor

I see.
My account -> Microsoft's one
Project -> Created with the above account and default settings.

takuro-sato added a commit that referenced this issue Nov 21, 2022
All PRs were squashed due to #43

Copy banking-app from https://github.com/takuro-sato/ccf-app-template/tree/example_apps (#7)

The repo was originally forked from https://github.com/microsoft/ccf-app-template

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Remove unused codes (#9)

* Remove unused codes

* Fix failed CI

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Update README.md (#10)

* Update README.md

* Fix README.md

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Update why ccf + Implement application claim for transfer (#12)

* Add 'why ccf' section

* Add application claim for transfer API

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Add 'Get claim' endpoint

* Update /receipt so that the response includes the expanded claim

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Remove /claim

Co-authored-by: Takuro Sato <takurosato@microsoft.com>
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

Clean up (#13)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Add features to devcontainer (#16)

* Add features to devcontainer

* npm install at container creation

Run tests in CI with virtual mode (#19)

* Run tests in CI

* Tidy up

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Added guidelines for running tests (#21)

Add linting (#20)

* Add linting

* Fix 'detected dubious ownership in repository' error

* See if CI fails as expected

* Revert "See if CI fails as expected"

This reverts commit 4570982.

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Add back 'Open in GitHub Codespaces' button (#22)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Use docker image that can use virtual (#25)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Create the user certs as part of the demo (#34)

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

GitHub Collaboration (#36)

* Added guide about board

* Typos

Added make file to hide scripts (#31)

* Add simple make commands

* Add initial devcontainer build

* Adding workflow-dispatch to test

* workflow_dispatch

* Add Safe Directory

* Pass GITHUB_WORKSPACE environment variable

* Added image that can use virtual

* Makefile per sample

* Amended CI

* Removed the banking-app clean from the root

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

Created set_js_app.json for governance (#33)

Split demo.sh into demo_governance.sh and demo_application.sh (#40)

* Split demo.sh into demo_governance.sh and demo_application.sh

* add more comments

* remove the extra echo line

* resolve review comments
@takuro-sato
Copy link
Contributor

I tried bfc and ten force pushed.
@ross-p-smith Could you try to import it again?

I got errors for updating PR refs (deny updating a hidden ref), but I see that the files are gone from the history of main.
If it doesn't work, I'll try to resolve the errors.

takurosato@LAPTOP-5I4F12NJ:~/Projects/CCF/repo/ccf-app-samples.git$ java -jar ~/bfg.jar --delete-files '{set_user0.json,set_user1.json,user0_cert.pem,user0_privk.pem,user1_cert.pem,user1_privk.pem}'

Using repo : /home/takurosato/Projects/CCF/repo/ccf-app-samples.git

Found 39 objects to protect
Found 23 commit-pointing refs : HEAD, refs/heads/main, refs/pull/10/head, ...

Protected commits
-----------------

These are your protected commits, and so their contents will NOT be altered:

 * commit 5817aca7 (protected by 'HEAD')

Cleaning
--------

Found 130 commits
Cleaning commits:       100% (130/130)
Cleaning commits completed in 264 ms.

Updating 21 Refs
----------------

        Ref                 Before     After   
        ---------------------------------------
        refs/pull/10/head | e9fad6c6 | bbedbb18
        refs/pull/11/head | ac99e48f | 6ce8b7fd
        refs/pull/12/head | 0c75d0c6 | 3869fcc4
        refs/pull/13/head | ba37374c | 0b1d4f9b
        refs/pull/16/head | a2b350b2 | c930fcd2
        refs/pull/19/head | 20ecc552 | b7f623e1
        refs/pull/20/head | 60eae65c | ee37bfdb
        refs/pull/21/head | 5a2ae178 | 519ab49b
        refs/pull/22/head | 6f90abee | fe7aa39a
        refs/pull/24/head | 5c8782b0 | 1a381c6f
        refs/pull/25/head | 47b30668 | f956f7f0
        refs/pull/31/head | 0cd9e995 | d3b75dfc
        refs/pull/33/head | 6f2ca657 | ef9d1cd7
        refs/pull/34/head | 0cd28ed2 | 25715c75
        refs/pull/36/head | b9481981 | d95f7cac
        ...

Updating references:    100% (21/21)
...Ref update completed in 43 ms.

Commit Tree-Dirt History
------------------------

        Earliest                                              Latest
        |                                                          |
        ..DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDmDmmmmmmmmmmmmmmmmmmDmmmmmm

        D = dirty commits (file tree fixed)
        m = modified commits (commit message or parents changed)
        . = clean commits (no changes to file tree)

                                Before     After   
        -------------------------------------------
        First modified commit | 5ef802e9 | 66f5f5b4
        Last dirty commit     | 4600c79a | 593dcfa1

Deleted files
-------------

        Filename          Git id                              
        ------------------------------------------------------
        set_user0.json  | 681452b6 (764 B ), 19e32c4e (802 B )
        set_user1.json  | eb77e737 (802 B ), f9e086ec (764 B )
        user0_cert.pem  | 0dfd546c (648 B )                   
        user0_privk.pem | 08307963 (359 B )                   
        user1_cert.pem  | 374255bd (648 B )                   
        user1_privk.pem | 843163e6 (359 B )                   


In total, 183 object ids were changed. Full details are logged here:

        /home/takurosato/Projects/CCF/repo/ccf-app-samples.git.bfg-report/2022-11-21/13-57-51

BFG run is complete! When ready, run: git reflog expire --expire=now --all && git gc --prune=now --aggressive
takurosato@LAPTOP-5I4F12NJ:~/Projects/CCF/repo/ccf-app-samples.git$ git push --force
Enumerating objects: 358, done.
Counting objects: 100% (358/358), done.
Delta compression using up to 8 threads
Compressing objects: 100% (122/122), done.
Writing objects: 100% (358/358), 65.54 KiB | 65.54 MiB/s, done.
Total 358 (delta 213), reused 358 (delta 213)
remote: Resolving deltas: 100% (213/213), completed with 32 local objects.
To https://github.com/microsoft/ccf-app-samples.git
 ! [remote rejected] refs/pull/10/head -> refs/pull/10/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/11/head -> refs/pull/11/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/12/head -> refs/pull/12/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/13/head -> refs/pull/13/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/16/head -> refs/pull/16/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/19/head -> refs/pull/19/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/20/head -> refs/pull/20/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/21/head -> refs/pull/21/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/22/head -> refs/pull/22/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/24/head -> refs/pull/24/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/25/head -> refs/pull/25/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/31/head -> refs/pull/31/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/33/head -> refs/pull/33/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/34/head -> refs/pull/34/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/36/head -> refs/pull/36/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/37/head -> refs/pull/37/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/40/head -> refs/pull/40/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/42/head -> refs/pull/42/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/44/head -> refs/pull/44/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/7/head -> refs/pull/7/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/9/head -> refs/pull/9/head (deny updating a hidden ref)
error: failed to push some refs to 'https://github.com/microsoft/ccf-app-samples.git'

@takuro-sato
Copy link
Contributor

According to rtyley/bfg-repo-cleaner#36 (comment), deny updating a hidden ref shouldn't be a problem.

takuro-sato added a commit that referenced this issue Nov 21, 2022
All PRs were squashed due to #43

Copy banking-app from https://github.com/takuro-sato/ccf-app-template/tree/example_apps (#7)

The repo was originally forked from https://github.com/microsoft/ccf-app-template

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Remove unused codes (#9)

* Remove unused codes

* Fix failed CI

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Update README.md (#10)

* Update README.md

* Fix README.md

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Update why ccf + Implement application claim for transfer (#12)

* Add 'why ccf' section

* Add application claim for transfer API

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Add 'Get claim' endpoint

* Update /receipt so that the response includes the expanded claim

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Remove /claim

Co-authored-by: Takuro Sato <takurosato@microsoft.com>
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

Clean up (#13)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Add features to devcontainer (#16)

* Add features to devcontainer

* npm install at container creation

Run tests in CI with virtual mode (#19)

* Run tests in CI

* Tidy up

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Added guidelines for running tests (#21)

Add linting (#20)

* Add linting

* Fix 'detected dubious ownership in repository' error

* See if CI fails as expected

* Revert "See if CI fails as expected"

This reverts commit 4570982.

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Add back 'Open in GitHub Codespaces' button (#22)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Use docker image that can use virtual (#25)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Create the user certs as part of the demo (#34)

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

GitHub Collaboration (#36)

* Added guide about board

* Typos

Added make file to hide scripts (#31)

* Add simple make commands

* Add initial devcontainer build

* Adding workflow-dispatch to test

* workflow_dispatch

* Add Safe Directory

* Pass GITHUB_WORKSPACE environment variable

* Added image that can use virtual

* Makefile per sample

* Amended CI

* Removed the banking-app clean from the root

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

Created set_js_app.json for governance (#33)

Split demo.sh into demo_governance.sh and demo_application.sh (#40)

* Split demo.sh into demo_governance.sh and demo_application.sh

* add more comments

* remove the extra echo line

* resolve review comments
takuro-sato added a commit that referenced this issue Nov 21, 2022
All PRs were squashed due to #43

Copy banking-app from https://github.com/takuro-sato/ccf-app-template/tree/example_apps (#7)

The repo was originally forked from https://github.com/microsoft/ccf-app-template

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Remove unused codes (#9)

* Remove unused codes

* Fix failed CI

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Update README.md (#10)

* Update README.md

* Fix README.md

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Update why ccf + Implement application claim for transfer (#12)

* Add 'why ccf' section

* Add application claim for transfer API

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Add 'Get claim' endpoint

* Update /receipt so that the response includes the expanded claim

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Remove /claim

Co-authored-by: Takuro Sato <takurosato@microsoft.com>
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

Clean up (#13)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Add features to devcontainer (#16)

* Add features to devcontainer

* npm install at container creation

Run tests in CI with virtual mode (#19)

* Run tests in CI

* Tidy up

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Added guidelines for running tests (#21)

Add linting (#20)

* Add linting

* Fix 'detected dubious ownership in repository' error

* See if CI fails as expected

* Revert "See if CI fails as expected"

This reverts commit 4570982.

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Add back 'Open in GitHub Codespaces' button (#22)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Use docker image that can use virtual (#25)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Create the user certs as part of the demo (#34)

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

GitHub Collaboration (#36)

* Added guide about board

* Typos

Added make file to hide scripts (#31)

* Add simple make commands

* Add initial devcontainer build

* Adding workflow-dispatch to test

* workflow_dispatch

* Add Safe Directory

* Pass GITHUB_WORKSPACE environment variable

* Added image that can use virtual

* Makefile per sample

* Amended CI

* Removed the banking-app clean from the root

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

Created set_js_app.json for governance (#33)

Split demo.sh into demo_governance.sh and demo_application.sh (#40)

* Split demo.sh into demo_governance.sh and demo_application.sh

* add more comments

* remove the extra echo line

* resolve review comments
@takuro-sato
Copy link
Contributor

We confirmed that the current main (18bf65d) has no problem with CredScan .

The current main was made using bfg tool.
Note: Due to the bug of Azure DevOps, the import needs to be done with CLI (Create an empty repo in Azure DevOps then push the content of the repo using git command).

@takuro-sato takuro-sato mentioned this issue Nov 23, 2022
1 task
ross-p-smith added a commit that referenced this issue Nov 23, 2022
* Copy banking-app from https://github.com/takuro-sato/ccf-app-template/tree/example_apps (#7)

The repo was originally forked from https://github.com/microsoft/ccf-app-template

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

* Remove unused codes (#9)

* Remove unused codes

* Fix failed CI

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

* Update README.md (#10)

* Update README.md

* Fix README.md

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

* Update why ccf + Implement application claim for transfer (#12)

* Add 'why ccf' section

* Add application claim for transfer API

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Add 'Get claim' endpoint

* Update /receipt so that the response includes the expanded claim

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Remove /claim

Co-authored-by: Takuro Sato <takurosato@microsoft.com>
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Clean up (#13)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

* Add features to devcontainer (#16)

* Add features to devcontainer

* npm install at container creation

* Run tests in CI with virtual mode (#19)

* Run tests in CI

* Tidy up

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

* Added guidelines for running tests (#21)

* Add linting (#20)

* Add linting

* Fix 'detected dubious ownership in repository' error

* See if CI fails as expected

* Revert "See if CI fails as expected"

This reverts commit 4570982.

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

* Add back 'Open in GitHub Codespaces' button (#22)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

* Use docker image that can use virtual (#25)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

* Create the user certs as part of the demo (#34)

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

* GitHub Collaboration (#36)

* Added guide about board

* Typos

* Added make file to hide scripts (#31)

* Add simple make commands

* Add initial devcontainer build

* Adding workflow-dispatch to test

* workflow_dispatch

* Add Safe Directory

* Pass GITHUB_WORKSPACE environment variable

* Added image that can use virtual

* Makefile per sample

* Amended CI

* Removed the banking-app clean from the root

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

* initial steps for moving certs from docker image

* adjusting build_image script and docker files

* Created set_js_app.json for governance (#33)

* updating script, readme and makefile

* updating ci.yml file to reflect new way of building containers

* prettifying README.md

* fixing typo on README.md

* Split demo.sh into demo_governance.sh and demo_application.sh (#40)

* Split demo.sh into demo_governance.sh and demo_application.sh

* add more comments

* remove the extra echo line

* resolve review comments

* changing folder structure for certificates to be the same as in sandbox flow

* Add banking-app

Some PRs were squashed due to #43

Copy banking-app from https://github.com/takuro-sato/ccf-app-template/tree/example_apps (#7)

The repo was originally forked from https://github.com/microsoft/ccf-app-template

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Remove unused codes (#9)

* Remove unused codes

* Fix failed CI

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Update README.md (#10)

* Update README.md

* Fix README.md

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Update why ccf + Implement application claim for transfer (#12)

* Add 'why ccf' section

* Add application claim for transfer API

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/README.md

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/test.sh

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Add 'Get claim' endpoint

* Update /receipt so that the response includes the expanded claim

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Update banking-app/src/endpoints/banking.ts

Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

* Remove /claim

Co-authored-by: Takuro Sato <takurosato@microsoft.com>
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

Clean up (#13)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Add features to devcontainer (#16)

* Add features to devcontainer

* npm install at container creation

Run tests in CI with virtual mode (#19)

* Run tests in CI

* Tidy up

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Added guidelines for running tests (#21)

Add linting (#20)

* Add linting

* Fix 'detected dubious ownership in repository' error

* See if CI fails as expected

* Revert "See if CI fails as expected"

This reverts commit 4570982.

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Add back 'Open in GitHub Codespaces' button (#22)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Use docker image that can use virtual (#25)

Co-authored-by: Takuro Sato <takurosato@microsoft.com>

Create the user certs as part of the demo (#34)

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

GitHub Collaboration (#36)

* Added guide about board

* Typos

Added make file to hide scripts (#31)

* Add simple make commands

* Add initial devcontainer build

* Adding workflow-dispatch to test

* workflow_dispatch

* Add Safe Directory

* Pass GITHUB_WORKSPACE environment variable

* Added image that can use virtual

* Makefile per sample

* Amended CI

* Removed the banking-app clean from the root

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>

Created set_js_app.json for governance (#33)

Split demo.sh into demo_governance.sh and demo_application.sh (#40)

* Split demo.sh into demo_governance.sh and demo_application.sh

* add more comments

* remove the extra echo line

* resolve review comments

Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com>
Co-authored-by: Takuro Sato <takurosato@microsoft.com>
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
Co-authored-by: Ross Smith <ross-p-smith@users.noreply.github.com>
Co-authored-by: Ayman <Aymalla@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants