Add banking-app #44
Closed
Add banking-app #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some PRs were squashed due to microsoft#43 Copy banking-app from https://github.com/takuro-sato/ccf-app-template/tree/example_apps (microsoft#7) The repo was originally forked from https://github.com/microsoft/ccf-app-template Co-authored-by: Takuro Sato <takurosato@microsoft.com> Remove unused codes (microsoft#9) * Remove unused codes * Fix failed CI Co-authored-by: Takuro Sato <takurosato@microsoft.com> Update README.md (microsoft#10) * Update README.md * Fix README.md Co-authored-by: Takuro Sato <takurosato@microsoft.com> Update why ccf + Implement application claim for transfer (microsoft#12) * Add 'why ccf' section * Add application claim for transfer API * Update banking-app/README.md Co-authored-by: Amaury Chamayou <amaury@xargs.fr> * Update banking-app/README.md Co-authored-by: Amaury Chamayou <amaury@xargs.fr> * Update banking-app/test.sh Co-authored-by: Amaury Chamayou <amaury@xargs.fr> * Update banking-app/README.md Co-authored-by: Amaury Chamayou <amaury@xargs.fr> * Update banking-app/test.sh Co-authored-by: Amaury Chamayou <amaury@xargs.fr> * Add 'Get claim' endpoint * Update /receipt so that the response includes the expanded claim * Update banking-app/src/endpoints/banking.ts Co-authored-by: Amaury Chamayou <amaury@xargs.fr> * Update banking-app/src/endpoints/banking.ts Co-authored-by: Amaury Chamayou <amaury@xargs.fr> * Remove /claim Co-authored-by: Takuro Sato <takurosato@microsoft.com> Co-authored-by: Amaury Chamayou <amaury@xargs.fr> Clean up (microsoft#13) Co-authored-by: Takuro Sato <takurosato@microsoft.com> Add features to devcontainer (microsoft#16) * Add features to devcontainer * npm install at container creation Run tests in CI with virtual mode (microsoft#19) * Run tests in CI * Tidy up Co-authored-by: Takuro Sato <takurosato@microsoft.com> Added guidelines for running tests (microsoft#21) Add linting (microsoft#20) * Add linting * Fix 'detected dubious ownership in repository' error * See if CI fails as expected * Revert "See if CI fails as expected" This reverts commit 4570982. Co-authored-by: Takuro Sato <takurosato@microsoft.com> Add back 'Open in GitHub Codespaces' button (microsoft#22) Co-authored-by: Takuro Sato <takurosato@microsoft.com> Use docker image that can use virtual (microsoft#25) Co-authored-by: Takuro Sato <takurosato@microsoft.com> Create the user certs as part of the demo (microsoft#34) Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com> GitHub Collaboration (microsoft#36) * Added guide about board * Typos Added make file to hide scripts (microsoft#31) * Add simple make commands * Add initial devcontainer build * Adding workflow-dispatch to test * workflow_dispatch * Add Safe Directory * Pass GITHUB_WORKSPACE environment variable * Added image that can use virtual * Makefile per sample * Amended CI * Removed the banking-app clean from the root Co-authored-by: Takuro Sato <79583855+takuro-sato@users.noreply.github.com> Created set_js_app.json for governance (microsoft#33) Split demo.sh into demo_governance.sh and demo_application.sh (microsoft#40) * Split demo.sh into demo_governance.sh and demo_application.sh * add more comments * remove the extra echo line * resolve review comments
|
Closing this because it seems to be not helpful to rewrite the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PRs were squashed due to #43
Copy banking-app from https://github.com/takuro-sato/ccf-app-template/tree/example_apps (#7)
The repo was originally forked from https://github.com/microsoft/ccf-app-template
Co-authored-by: Takuro Sato takurosato@microsoft.com
Remove unused codes (#9)
Remove unused codes
Fix failed CI
Co-authored-by: Takuro Sato takurosato@microsoft.com
Update README.md (#10)
Update README.md
Fix README.md
Co-authored-by: Takuro Sato takurosato@microsoft.com
Update why ccf + Implement application claim for transfer (#12)
Add 'why ccf' section
Add application claim for transfer API
Update banking-app/README.md
Co-authored-by: Amaury Chamayou amaury@xargs.fr
Co-authored-by: Amaury Chamayou amaury@xargs.fr
Co-authored-by: Amaury Chamayou amaury@xargs.fr
Co-authored-by: Amaury Chamayou amaury@xargs.fr
Co-authored-by: Amaury Chamayou amaury@xargs.fr
Add 'Get claim' endpoint
Update /receipt so that the response includes the expanded claim
Update banking-app/src/endpoints/banking.ts
Co-authored-by: Amaury Chamayou amaury@xargs.fr
Co-authored-by: Amaury Chamayou amaury@xargs.fr
Co-authored-by: Takuro Sato takurosato@microsoft.com
Co-authored-by: Amaury Chamayou amaury@xargs.fr
Clean up (#13)
Co-authored-by: Takuro Sato takurosato@microsoft.com
Add features to devcontainer (#16)
Add features to devcontainer
npm install at container creation
Run tests in CI with virtual mode (#19)
Run tests in CI
Tidy up
Co-authored-by: Takuro Sato takurosato@microsoft.com
Added guidelines for running tests (#21)
Add linting (#20)
Add linting
Fix 'detected dubious ownership in repository' error
See if CI fails as expected
Revert "See if CI fails as expected"
This reverts commit 4570982.
Co-authored-by: Takuro Sato takurosato@microsoft.com
Add back 'Open in GitHub Codespaces' button (#22)
Co-authored-by: Takuro Sato takurosato@microsoft.com
Use docker image that can use virtual (#25)
Co-authored-by: Takuro Sato takurosato@microsoft.com
Create the user certs as part of the demo (#34)
Co-authored-by: Takuro Sato 79583855+takuro-sato@users.noreply.github.com
GitHub Collaboration (#36)
Added guide about board
Typos
Added make file to hide scripts (#31)
Add simple make commands
Add initial devcontainer build
Adding workflow-dispatch to test
workflow_dispatch
Add Safe Directory
Pass GITHUB_WORKSPACE environment variable
Added image that can use virtual
Makefile per sample
Amended CI
Removed the banking-app clean from the root
Co-authored-by: Takuro Sato 79583855+takuro-sato@users.noreply.github.com
Created set_js_app.json for governance (#33)
Split demo.sh into demo_governance.sh and demo_application.sh (#40)
Split demo.sh into demo_governance.sh and demo_application.sh
add more comments
remove the extra echo line
resolve review comments