Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the debugger knows DATAS is on #1301

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

cshung
Copy link
Member

@cshung cshung commented Jan 9, 2025

This PR is meant to support dotnet/diagnostics#5090.

This PR is the clrmd side of the work, this exposes a new field so that the debugger can display the information.
There are two more PRs on different repos to support this:

On runtime: dotnet/runtime#107115
On diagnostics: dotnet/diagnostics#5164

Copy link
Member

@mikem8361 mikem8361 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @leculver do you want to review?

Copy link
Contributor

@leculver leculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leculver leculver merged commit 59e8f8b into microsoft:main Jan 13, 2025
8 checks passed
mikem8361 pushed a commit to dotnet/diagnostics that referenced this pull request Jan 24, 2025
This PR is meant to support
#5090.

This PR is the diagnostics side of the work, this exposes a new field so
that the debugger can display the information.
There are two more PRs on different repos to support this:

The code won't compile until the clrmd dependency is consumed.

On runtime: dotnet/runtime#107115
On clrmd: microsoft/clrmd#1301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants