Skip to content

Commit

Permalink
Revert "Add General Feedback option (#1741)" (#1807)
Browse files Browse the repository at this point in the history
This reverts commit 570e33e.
  • Loading branch information
EricJohnson327 committed Nov 1, 2023
1 parent 570e33e commit 5dc7dc9
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 75 deletions.
37 changes: 0 additions & 37 deletions settings/DevHome.Settings/Strings/en-us/Resources.resw
Original file line number Diff line number Diff line change
Expand Up @@ -193,43 +193,6 @@
<data name="Settings_About_RelatedLinks.Text" xml:space="preserve">
<value>Related links</value>
</data>
<data name="Settings_Feedback_BlankIssue.Header" xml:space="preserve">
<value>General feedback</value>
<comment>BlankIssue is for general feedback that does not categorize under given options</comment>
</data>
<data name="Settings_Feedback_BlankIssue.Description" xml:space="preserve">
<value>Give general comments and suggestions</value>
<comment>Details about when this option should be used</comment>
</data>
<data name="Settings_Feedback_BlankIssue_Button.Content" xml:space="preserve">
<value>Feedback</value>
<comment>Begin to fill out the blank issue content dialog</comment>
</data>
<data name="Settings_Feedback_BlankIssue_Dialog.CloseButtonText" xml:space="preserve">
<value>Cancel</value>
<comment>Close out of the content dialog</comment>
</data>
<data name="Settings_Feedback_BlankIssue_Dialog.PrimaryButtonText" xml:space="preserve">
<value>Preview on GitHub</value>
<comment>Navigate to the GitHub issue to see the issue form</comment>
</data>
<data name="Settings_Feedback_BlankIssue_Dialog.Title" xml:space="preserve">
<value>Give general feedback</value>
</data>
<data name="Settings_Feedback_BlankIssue_IssueTitle.Header" xml:space="preserve">
<value>Title</value>
</data>
<data name="Settings_Feedback_BlankIssue_IssueTitle.PlaceholderText" xml:space="preserve">
<value>Enter title</value>
<comment>General feedback title</comment>
</data>
<data name="Settings_Feedback_BlankIssue_Description.Header" xml:space="preserve">
<value>Description</value>
</data>
<data name="Settings_Feedback_BlankIssue_Description.PlaceholderText" xml:space="preserve">
<value>Share your thoughts with us.</value>
<comment>General feedback description</comment>
</data>
<data name="Settings_Feedback_Header" xml:space="preserve">
<value>Feedback</value>
</data>
Expand Down
17 changes: 0 additions & 17 deletions settings/DevHome.Settings/Views/FeedbackPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,6 @@
</ScrollViewer>
</Grid>
</ContentDialog>
<ContentDialog x:Name="BlankIssueDialog" x:Uid="Settings_Feedback_BlankIssue_Dialog" HorizontalAlignment="Center" DefaultButton="Primary">
<Grid>
<ScrollViewer VerticalScrollBarVisibility="Auto">
<StackPanel>
<TextBox x:Name="BlankIssueTitle" x:Uid="Settings_Feedback_BlankIssue_IssueTitle" AcceptsReturn="True"/>
<TextBox x:Name="BlankIssueDescription" x:Uid="Settings_Feedback_BlankIssue_Description" TextWrapping="Wrap" Margin="{StaticResource SmallTopMargin}" Height="{StaticResource FeedbackTextBoxHeight}" AcceptsReturn="True"/>
</StackPanel>
</ScrollViewer>
</Grid>
</ContentDialog>
<TextBlock Margin="{StaticResource MediumBottomMargin}" TextWrapping="WrapWholeWords">
<Run x:Uid="Settings_Feedback_OpenSource"/>
<Hyperlink x:Uid="Settings_Feedback_OpenSource_Link" TextDecorations="None">
Expand Down Expand Up @@ -128,13 +118,6 @@
</ctControls:SettingsCard.HeaderIcon>
<Button x:Uid="Settings_Feedback_LocalizationIssue_Button" Click="DisplayLocalizationIssueDialog" MinWidth="150" />
</ctControls:SettingsCard>
<ctControls:SettingsCard x:Uid="Settings_Feedback_BlankIssue">
<ctControls:SettingsCard.HeaderIcon>
<FontIcon FontFamily="{StaticResource SymbolThemeFontFamily}"
Glyph="&#xe89c;"/>
</ctControls:SettingsCard.HeaderIcon>
<Button x:Uid="Settings_Feedback_BlankIssue_Button" Click="DisplayBlankIssueDialog" MinWidth="150" />
</ctControls:SettingsCard>
<ctControls:SettingsCard x:Uid="Settings_Feedback_BuildExtension">
<ctControls:SettingsCard.HeaderIcon>
<FontIcon FontFamily="{StaticResource SymbolThemeFontFamily}"
Expand Down
21 changes: 0 additions & 21 deletions settings/DevHome.Settings/Views/FeedbackPage.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -165,27 +165,6 @@ private async void DisplayReportBugDialog(object sender, RoutedEventArgs e)
ReportBugIssueTitle.Text = ReportBugReproSteps.Text = ReportBugExpectedBehavior.Text = ReportBugActualBehavior.Text = string.Empty;
}

private async void DisplayBlankIssueDialog(object sender, RoutedEventArgs e)
{
var result = await BlankIssueDialog.ShowAsync();
if (result == ContentDialogResult.Primary)
{
var issueTitle = HttpUtility.UrlEncode(BlankIssueTitle.Text);
var issueDescription = HttpUtility.UrlEncode(BlankIssueDescription.Text);
var gitHubURL = "https://github.com/microsoft/devhome/issues/new?title=" + issueTitle +
"&body=" + issueDescription;

// Make sure any changes are consistent with the translation issue template on GitHub
await Windows.System.Launcher.LaunchUriAsync(new Uri(gitHubURL));
}
else
{
BlankIssueDialog.Hide();
}

BlankIssueTitle.Text = BlankIssueDescription.Text = string.Empty;
}

private void ShowSysInfoExpander_Expanding(Expander sender, ExpanderExpandingEventArgs args)
{
PhysicalMemory.Text = GetPhysicalMemory();
Expand Down

0 comments on commit 5dc7dc9

Please sign in to comment.