-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add General Feedback option #1741
Conversation
@cinnamon-msft I think we would need Design to weigh in on this, yeah? |
I don't think we should hold this on design - this looks good to me and we can always tweak it after design gets a chance to look at it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hamnarauf I'm sorry to ask this of you, but we discussed this issue and we'd like to pivot from a "General Feedback" option to exposing the "Documentation issue" type that is available in the GitHub website, but isn't available in Dev Home.
The issue template is here: https://github.com/microsoft/devhome/issues/new?assignees=&labels=Issue-Docs&projects=&template=Documentation_Issue.yml
If you don't mind changing your PR to implement this instead, I think the only work needed is updating the strings that are displayed and some variable names.
Thank you so much for your contribution, and I'm sorry it took us a while to get back to you!
This reverts commit 570e33e.
Alright, since this one got prematurely merged, I'll open a new PR supporting "Documentation" issue. |
Summary of the pull request
Added a new option to provide a "General Feedback" in Settings > Feedback section. This option will allow users to give feedback that doesn't categorize in the current options for giving feedback.
References and relevant issues
#1115
Detailed description of the pull request / Additional comments
Validation steps performed
Created an issue via "General Feedback" option:
PR checklist