Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Widget customization #1819

Merged
merged 8 commits into from
Nov 7, 2023
Merged

Implement Widget customization #1819

merged 8 commits into from
Nov 7, 2023

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Nov 2, 2023

Summary of the pull request

Instead of faking widget customization by creating a new widget in the old one's place, do it for real with the new IWidgetProvider2 interface.

Note: this will remove the Customize menu option for all widgets that have not yet implemented the new interface.

  • Update Dev Home to use WinAppSDK 1.4, so we have access to the new API
  • Move customization experience to be in-place, rather than in a pop-up

References and relevant issues

Detailed description of the pull request / Additional comments

  • When customization is selected, Dev Home uses the new Widget.NotifyCustomizationRequestedAsync() API to notify the widget provider. The Widget provider will receive a OnCustomizationRequested event.
  • Add "Save" and "Cancel" buttons during editing experience.

Not yet implemented:

  • Localization for new buttons

Here's the SSH keychain:
image
Edit: this will now show the previously selected file:
image
image
image

Validation steps performed

PR checklist

@krschau krschau merged commit d6cd544 into main Nov 7, 2023
4 checks passed
@krschau krschau deleted the user/krschau/customize branch November 7, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Home does not support Windows Widget IsCustomizable package manifest value
3 participants