Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable widget customization #262

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Enable widget customization #262

merged 6 commits into from
Nov 8, 2023

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Nov 7, 2023

Summary of the pull request

Implement customization enabled by microsoft/devhome#1819

When the user selects "Customize" in the widget menu, the widget will switch to its customization flow. From there, they can edit the data they put in during the "add" flow and save, or cancel and revert everything back to the way the widget was before.

By implementing the IWidgetProvider2 interface provided by WinAppSDK 1.4, the widget can opt into receiving notifications when the user selects the "Customize" menu, and provide this experience. Otherwise, customization menu item is not available.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@krschau krschau merged commit 152a60c into main Nov 8, 2023
4 checks passed
@krschau krschau deleted the user/krschau/customize branch November 8, 2023 00:08
@krschau krschau linked an issue Nov 8, 2023 that may be closed by this pull request
@krschau krschau marked this as a duplicate of #113 Nov 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution-Duplicate This issue or pull request already exists label Nov 14, 2023
@krschau krschau marked this as not a duplicate of #113 Nov 14, 2023
@krschau krschau removed the Resolution-Duplicate This issue or pull request already exists label Nov 14, 2023
EricJohnson327 pushed a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support widget customization [Widgets] Repo/query field shouldn't be blank if you "Customize" PR Widget
3 participants