Detecting configuration files #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
requested review from
jsidewhite,
nieubank,
huzaifa-d,
vineeththomasalex,
dkbennett,
krschau,
EricJohnson327,
sshilov7,
brialmsft,
hart-wilson,
SohamDas2021,
AmelBawa-msft,
bbonaby and
TWhiteDesigns
krschau
reviewed
Mar 27, 2024
tools/SetupFlow/DevHome.SetupFlow/Models/ConfigureTargetTask.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/Models/ConfigureTargetTask.cs
Outdated
Show resolved
Hide resolved
jsidewhite
reviewed
Mar 28, 2024
jsidewhite
reviewed
Mar 28, 2024
jsidewhite
reviewed
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/CloneRepoSummaryInformationFileViewModel.cs
Outdated
Show resolved
Hide resolved
jsidewhite
reviewed
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/CloneRepoSummaryInformationFileViewModel.cs
Outdated
Show resolved
Hide resolved
jsidewhite
reviewed
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/CloneRepoSummaryInformationFileViewModel.cs
Show resolved
Hide resolved
jsidewhite
reviewed
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/CloneRepoSummaryInformationFileViewModel.cs
Outdated
Show resolved
Hide resolved
jsidewhite
reviewed
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/CloneRepoSummaryInformationFileViewModel.cs
Show resolved
Hide resolved
jsidewhite
reviewed
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/CloneRepoSummaryInformationFileViewModel.cs
Outdated
Show resolved
Hide resolved
jsidewhite
reviewed
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/CloneRepoSummaryInformationFileViewModel.cs
Show resolved
Hide resolved
jsidewhite
reviewed
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/CloneRepoSummaryInformationFileViewModel.cs
Outdated
Show resolved
Hide resolved
jsidewhite
reviewed
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/SummaryViewModel.cs
Outdated
Show resolved
Hide resolved
jsidewhite
reviewed
Mar 28, 2024
jsidewhite
reviewed
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/CloneRepoSummaryInformationFileViewModel.cs
Show resolved
Hide resolved
3 tasks
jsidewhite
reviewed
Mar 29, 2024
tools/SetupFlow/DevHome.SetupFlow/Views/CloneRepoSummaryInformationView.xaml.cs
Show resolved
Hide resolved
vineeththomasalex
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
DevHome will now detect a configuration file in a repos .configuration folder. If one is found, the file name, along with the repo name, will be shown in the summary screen along with two options.
Running the file opens up an admin CMD with "winget [filename]"
This PR includes the ability for other tasks to add their own custom next steps that will show in the summary screen.
References and relevant issues
This PR also moves LoadingMessageViewModel into the service collection.
Detailed description of the pull request / Additional comments
Validation steps performed
Manually ran the scenarios including making a devdrive and cloning.
PR checklist
Movies!
All repos downloaded have a config file + view file and run file
Some config files found. One repo encountered an error
Pictures!
More repos cloned than config files found
Loading screen errors and no config files found.
