Change GetWidgetsAsync to always return a valid list #2687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Changes GetWidgetsAsync to always return a list instead of a list or null. Returning null is what the underlying GetWidgets() returns and that seems to slip through the nullable type checking. This change ensures GetWidgetsAsync always returns a list of Widgets, or an empty list if there were errors or null was returned from GetWidgets().
This fixes the empty pin widgets dialog when there were no widgets because the list was null and not checked, causing the dialog to crash. Null check is no longer required and this method will always have a valid list.
References and relevant issues
Closes #2686
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist