Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information button name and TeachingTip narrations to Review and Finish page #3497

Merged

Conversation

lauren-ciha
Copy link
Contributor

@lauren-ciha lauren-ciha commented Jul 25, 2024

Summary of the pull request

This PR adds two missing narrations to the Review and Finish page:

  • The information button next to the "Generate Configuration file" button
  • The content of the TeachingTip on that information button

The information button next to the "Generate Configuration file" button

Before:

before_info_icon_name_change.mp4

After changes:

info_button_narration.mp4

The information button's TeachingTip content

Before:

before_info_icon_changes.mp4

After changes:

info_button_tip_narration.mp4

References and relevant issues

Resolves:

Works around:

Detailed description of the pull request / Additional comments

I had to use a workaround to make the TeachingTip text readable:

  • Change the text inside from a Subtitle to a Title (which bolded the text)
  • Set IsLightDismissEnabled to false (which added the close button)

Although the workaround makes some minor cosmetic changes, I believe those are worth the additional functionality until the WinUI 3 TeachingTip is updated.

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@lauren-ciha lauren-ciha changed the title Add narration to Review and Finish page Add information button name and TeachingTip narration to Review and Finish page Jul 25, 2024
@lauren-ciha lauren-ciha changed the title Add information button name and TeachingTip narration to Review and Finish page Add information button name and TeachingTip narrations to Review and Finish page Jul 25, 2024
@lauren-ciha lauren-ciha marked this pull request as ready for review July 25, 2024 21:41
@dhoehna
Copy link
Contributor

dhoehna commented Jul 26, 2024

Change the text inside from a Subtitle to a Title (which bolded the text)
Why is this part of the work around?

@lauren-ciha
Copy link
Contributor Author

lauren-ciha commented Jul 26, 2024

Change the text inside from a Subtitle to a Title (which bolded the text)
Why is this part of the work around?

When I had just IsLightDismissEnabled set to false, the Subtitle wasn't read:

subtitle_teachingtip_bug.mp4

I found that the Subtitles weren't narrated in the WinUI 3 Gallery as well. I'm not sure if that's by design. I mentioned this in the winui-xaml issue so their team is aware of it.

@lauren-ciha lauren-ciha merged commit 51d09d8 into main Jul 31, 2024
4 checks passed
@krschau krschau added this to the Dev Home v0.17 milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants