Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information button name and TeachingTip narrations to Review and Finish page #3497

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Add information button name and TeachingTip narrations to Review and Finish page #3497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
757775c
Add narration to generate config file info button
lauren-ciha Jul 25, 2024
1322d9e
Make Generate Configuration info TeachingTip readable
lauren-ciha Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tools/SetupFlow/DevHome.SetupFlow/Strings/en-us/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@
<value>Generate Configuration file</value>
<comment>Text for a generating configuration file button</comment>
</data>
<data name="Review_DownloadFileTooltip.Subtitle" xml:space="preserve">
<data name="Review_DownloadFileTooltip.Title" xml:space="preserve">
<value>Generate a WinGet Configuration file (.winget) to repeat this setup in the future or share it with others.</value>
<comment>{Locked="WinGet",".winget"}Tooltip text about the generated configuration file</comment>
</data>
Expand Down Expand Up @@ -2023,4 +2023,8 @@
<value>Close</value>
<comment>Close button automation name for the login UI dialog</comment>
</data>
<data name="GenerateConfigInfoButton.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Generate configuration file info</value>
<comment>Narration for the informational icon next to the "Generate Configuration file" button</comment>
</data>
</root>
3 changes: 2 additions & 1 deletion tools/SetupFlow/DevHome.SetupFlow/Views/ReviewView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
x:Uid="Review_GenerateConfigurationFileButton"/>
<!-- Info icon -->
<Button Style="{ThemeResource AlternateCloseButtonStyle}"
x:Uid="GenerateConfigInfoButton"
x:Name="GenerateConfigInfoButton"
PointerEntered="GenerateConfigInfoButton_PointerEntered"
Click="GenerateConfigInfoButton_Click">
Expand All @@ -89,7 +90,7 @@
<TeachingTip x:Name="GenerateConfigInfoTeachingTip"
x:Uid="Review_DownloadFileTooltip"
Target="{x:Bind GenerateConfigInfoButton}"
IsLightDismissEnabled="True"/>
IsLightDismissEnabled="False"/>
</StackPanel>
</Grid>
</Expander.Header>
Expand Down
Loading