Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing Repository Management actions + Database changes. #3836

Merged
merged 47 commits into from
Sep 19, 2024
Merged

Implementing Repository Management actions + Database changes. #3836

merged 47 commits into from
Sep 19, 2024

Conversation

dhoehna
Copy link
Contributor

@dhoehna dhoehna commented Sep 11, 2024 •
edited
Loading

Summary of the pull request

This PR allows users to

  1. Remove the repository from the list
  2. Delete the Repository
  3. Run the repositories WinGet configuration file
  4. Make a new WinGet configuration file with the selected repository
  5. Open FE to the repository root
  6. Open CCMD to the repository root
  7. Add an existing repository to the list
  8. Navigate to the clone repository flow.

All from the repository management page! Yay!

In addition to logic changes. I made some database changes

  1. Removed RepositoryMetadata. IsHidden is part of the Repository entity
  2. Moved RepositoryManagementDataAccessService to DevHome.Database to prevent a circular dependency. Now I can call MakeConfigurationFileFromRepoAndGit without moving the code base to a new project.
  3. Added another Repository test.
  4. Added the following to Repository
    1. RepositoryClonePath
    2. HasConfigurationFile
    3. ConfigurationFileLocation
    4. RepositoryUri

Another change is in Navigation. Changed navigation to use a Dictionary instead of multiple if/else.

References and relevant issues

Detailed description of the pull request / Additional comments

This PR has many TODO:'s and they will be removed in another PR this week as I address them.
This feature is still experimental.

Validation steps performed

PR checklist

  • Closes #xxx
  • [X ] Tests added/passed
  • Documentation updated

dhoehna and others added 30 commits August 13, 2024 12:23
@dhoehna @krschau
Refining Repository Management's UI. (#3557)
fc754c1 
* Adding the Repository tool

* WIP

* View is set up.  Test ata as well.

* Aligning columns.  Adding column spacing.

* Reverting this change

* Update tools/RepositoryManagement/DevHome.RepositoryManagement/Strings/en-us/Resources.resw

Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>

* Adressing comments

* Revert "Reverting this change"

This reverts commit 711dd78.

* Moving to experimental

* Disabling by default

* Removing from experimental.  Addressing comments.

* Reverting to main

* Update tools/RepositoryManagement/DevHome.RepositoryManagement/DevHome.RepositoryManagement.csproj

Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>

* Update tools/RepositoryManagement/DevHome.RepositoryManagement/Extensions/ServiceExtensions.cs

Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>

* Removing duplicate xaml code

* Adding to the mermaid diagram

* Got lost in the shuffle

* Removing a refrence

---------

Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
@dhoehna
Merge branch 'main' into user/dhoehna/RepositoryManagementFeature
e52afbf
@dhoehna
Adding EF core, database project, and some usage. (#3674)
7d00a02 
* WIP

* EF works.  Can save data.

* Can read and write. :)

* Repos are added when cloned.

* Putting save/load into a different class

* Adding default values

* Cleaning up names and using statements

* More comments

* Removing refrence to the public nuget

* Restoring the nuget config

* Adding a test.  Better defining dates

* Adding some tests

* More comments.

* Better path comparison.

* Removing unused equals code

* Adding more comments.  Making new migrations
@dhoehna
Merge branch 'main' into user/dhoehna/RepositoryManagementFeature
cd2f925
@dhoehna
Merge branch 'user/dhoehna/RepositoryManagementFeature' of https://gi…
6775301 
…thub.com/microsoft/devhome into user/dhoehna/RepositoryManagementFeature
@dhoehna
Moving this to experimental
9d77f68
@dhoehna
WIP
17cc488
@dhoehna
Some telemetry and logging
66f6978
@dhoehna
THings build again.
8606981
@dhoehna
Returning this back
241bcee
@dhoehna
I believe I am understanding this.
234af67
@dhoehna
Can update
038c65b
@dhoehna
Almost done with open in FE
e45e669
@dhoehna
Try/Catching everything. Open in FE should be done.
0d39cd6
@dhoehna
Open in CMD works. :)
d6f4f44
@dhoehna
Merge branch 'main' into user/dhoehna/ImplementingTheRepositoryActions
e3b552e
@dhoehna
Re-adding changes lost due to merge
1d628c7
@dhoehna
Getting saving straightened out.
d23a431
@dhoehna
Merge branch 'main' into user/dhoehna/ImplementingTheRepositoryActions
6b7b72e
@dhoehna
WIP
d73857d
@dhoehna
Move Repository done.
87a1a38
@dhoehna
Removing 1:1. Finishing RemoveFromList
5395f4c
@dhoehna
Adding _items
022977a
@dhoehna
Adding configuration file information to the repository table
7fe619c
@dhoehna
Opening the configuration file location in FE
5655157
@dhoehna
Deleting a repository.
2ef3922
@dhoehna
Add to winget configuration file.
2c44c31
@dhoehna
Cleaning up the code
cfa8f9a
@dhoehna
Icon for a configuration file. UI updates when hiding a repo
0c00fca
@dhoehna
All the buttons do something.
4135ec4
@dhoehna dhoehna requested review from bbonaby, ssparach and a team September 11, 2024 17:35
@krschau krschau added this to the Dev Home v0.19 milestone Sep 11, 2024
bbonaby
bbonaby reviewed Sep 13, 2024
View reviewed changes
common/Services/INavigationService.cs Outdated Show resolved Hide resolved
common/TelemetryEvents/DevHomeDatabase/DevHomeDatabaseContextEvent.cs Outdated Show resolved Hide resolved
common/TelemetryEvents/RepositoryManagement/RepositoryLineItemErrorEvent.cs Show resolved Hide resolved
common/TelemetryEvents/RepositoryManagement/RepositoryLineItemEvent.cs Show resolved Hide resolved
database/DevHome.Database/DatabaseModels/RepositoryManagement/Repository.cs Outdated Show resolved Hide resolved
...itoryManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementItemViewModel.cs Show resolved Hide resolved
...itoryManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementItemViewModel.cs Show resolved Hide resolved
...itoryManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementItemViewModel.cs Show resolved Hide resolved
...itoryManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementItemViewModel.cs Outdated Show resolved Hide resolved
...itoryManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementItemViewModel.cs Show resolved Hide resolved
vineeththomasalex
vineeththomasalex reviewed Sep 18, 2024
View reviewed changes
database/DevHome.Database/DevHomeDatabaseContext.cs
public class DevHomeDatabaseContext : DbContext
{
public DbSet<Repository> Repositories { get; set; }
private const string DatabaseFileName = "DevHome.db";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add a Const value for this file name/path and add it somewhere central (like config?).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'm also not a fan of the name "DevHome.db". Mabye something like "DevHomeMachineData.db" to reflect that this is data about what's on the machine (at least that's what I think this is for) :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The database is for all of devhome.

I'll look into making the path, and name const

DevHome.db is for all of DevHome local for every user.

Maybe UserDevHomeData.db?

vineeththomasalex
vineeththomasalex approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@vineeththomasalex vineeththomasalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing blocking, and TODO's are being taken care of in https://github.com/microsoft/devhome/tree/user/dhoehna/DatabaseMigrationsAndTodos

@dhoehna dhoehna merged commit 6b805e3 into main Sep 19, 2024
4 checks passed
@dhoehna dhoehna mentioned this pull request Sep 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbonaby bbonaby bbonaby approved these changes

@vineeththomasalex vineeththomasalex vineeththomasalex approved these changes

@jsidewhite jsidewhite Awaiting requested review from jsidewhite

@nieubank nieubank Awaiting requested review from nieubank

@guimafelipe guimafelipe Awaiting requested review from guimafelipe

@huzaifa-d huzaifa-d Awaiting requested review from huzaifa-d

@dkbennett dkbennett Awaiting requested review from dkbennett

@jaholme jaholme Awaiting requested review from jaholme

@AgneLukoseviciute AgneLukoseviciute Awaiting requested review from AgneLukoseviciute

@krschau krschau Awaiting requested review from krschau

@EricJohnson327 EricJohnson327 Awaiting requested review from EricJohnson327

@sshilov7 sshilov7 Awaiting requested review from sshilov7

@hart-wilson hart-wilson Awaiting requested review from hart-wilson

@lauren-ciha lauren-ciha Awaiting requested review from lauren-ciha

@zadesai zadesai Awaiting requested review from zadesai

@SohamDas2021 SohamDas2021 Awaiting requested review from SohamDas2021

@AmelBawa-msft AmelBawa-msft Awaiting requested review from AmelBawa-msft

@ssparach ssparach Awaiting requested review from ssparach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Dev Home v0.19
Development

Successfully merging this pull request may close these issues.
4 participants
@dhoehna @vineeththomasalex @bbonaby @krschau